[SPARK-54910][SS] Add sourceIdentifyingName parameter to StreamingRelationV2 #53704
+30
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ationV2 ## What changes were proposed in this pull request? This PR adds the `sourceIdentifyingName` parameter to `StreamingRelationV2` and introduces the `HasStreamingSourceIdentifyingName` trait to provide a uniform interface for streaming source naming. Key changes: - Added `HasStreamingSourceIdentifyingName` trait in `StreamingSourceIdentifyingName.scala` - Added `sourceIdentifyingName` parameter to `StreamingRelationV2` case class with default value `Unassigned` - Implemented `withSourceIdentifyingName` method to support name propagation - Updated all pattern matches for `StreamingRelationV2` in sql/core to account for new parameter - Updated explain test golden file to include the new parameter in output ## Why are the changes needed? This change lays the groundwork for streaming source evolution by enabling sources to have stable identifying names. The parameter will be used by analyzer rules to assign and propagate names from DataFrame API calls, allowing sources to maintain their checkpoint state even when sources are added, removed, or reordered in a query. ## Does this PR introduce _any_ user-facing change? No. The parameter is added with a default value (`Unassigned`) that maintains backward compatibility. No user-facing APIs are modified. ## How was this patch tested? - Updated ProtoToPlan explain test to verify the parameter appears correctly in explain output - Verified pattern matches compile correctly with the new parameter - All existing tests pass with the new parameter ## Was this patch authored or co-authored using generative AI tooling? No.
JIRA Issue Information=== Task SPARK-54910 === This comment was automatically generated by GitHub Actions |
Contributor
Author
|
cc @HeartSaVioR Can you PTAL? |
anishshri-db
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds the
sourceIdentifyingNameparameter toStreamingRelationV2and introduces theHasStreamingSourceIdentifyingNametrait to provide a uniform interface for streaming source naming.Key changes:
HasStreamingSourceIdentifyingNametrait inStreamingSourceIdentifyingName.scalasourceIdentifyingNameparameter toStreamingRelationV2case class with default valueUnassignedwithSourceIdentifyingNamemethod to support name propagationStreamingRelationV2in sql/core to account for new parameterWhy are the changes needed?
This change lays the groundwork for streaming source evolution by enabling sources to have stable identifying names. The parameter will be used by analyzer rules to assign and propagate names from DataFrame API calls, allowing sources to maintain their checkpoint state even when sources are added, removed, or reordered in a query.
Does this PR introduce any user-facing change?
No. The parameter is added with a default value (
Unassigned) that maintains backward compatibility. No user-facing APIs are modified.How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.