Skip to content

[SPARK-54930][PYTHON] Remove redundant _accumulatorRegistry.clear() call in worker.py #53708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yicong-Huang wants to merge 1 commit into from
Closed

[SPARK-54930][PYTHON] Remove redundant _accumulatorRegistry.clear() call in worker.py #53708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion python/pyspark/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3493,7 +3493,6 @@ def main(infile, outfile):

shuffle.MemoryBytesSpilled = 0
shuffle.DiskBytesSpilled = 0
_accumulatorRegistry.clear()
Copy link
Member

@HyukjinKwon HyukjinKwon Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it's a safeguard because accumulator server is running async, and when the worker is reused ... but not sure. just speculating it. Can we dig the commits and see if there are any hint related to it?

Copy link
Member

@HyukjinKwon HyukjinKwon Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you already did in the pr description

Copy link
Member

@HyukjinKwon HyukjinKwon Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok seems a mistake

Copy link
Contributor Author

@Yicong-Huang Yicong-Huang Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I didn’t see a strong justification to keep it based on the previous PRs. Happy to revisit if we think there’s a concrete scenario we’re missing.


setup_spark_files(infile)
setup_broadcasts(infile)
Expand Down