[SPARK-49872][FOLLOWUP] Remove Jackson JSON string length limit in KVStoreScalaSerializer #53711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…StoreScalaSerializer
JIRA Issue Information=== Bug SPARK-49872 === This comment was automatically generated by GitHub Actions |
Contributor
|
thanks, merging to master/4.1/4.0/3.5! |
cloud-fan
pushed a commit
that referenced
this pull request
Jan 7, 2026
…StoreScalaSerializer ### What changes were proposed in this pull request? Along the same lines as #52049, apply the same fix to `KVStoreScalaSerializer` as well. ### Why are the changes needed? The previous fix in #52049 only removed the Jackson JSON string length limit in `JsonProtocol`, which covered Spark event <=> JSON SerDe. However, the exact same problem exists in `KVStoreScalaSerializer` as well, which is triggered when SHS is configured to use LevelDB/RocksDB KVStores. Example call chain that triggers the issue: ``` ExecutionPage.render() → sqlStore.planGraph(executionId, version) → store.read(classOf[SparkPlanGraphWrapper], ...) → KVStoreSerializer.deserialize() → mapper.readValue() // ← FAILS HERE with 20MB limit ``` ### Does this PR introduce _any_ user-facing change? Yes, users won't hit the Jackson JSON string length limit any more when using SHS. ### How was this patch tested? Manually tested with a SQL workload that had an intentionally long string for the plan graph. The fix mechanism itself is tested by previous PRs #49163 and #52049, this is just applying the same fix to SHS as well. ### Was this patch authored or co-authored using generative AI tooling? No Closes #53711 from rednaxelafx/fix-jackson-strlenlimit-kvstore. Authored-by: Kris Mok <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit ed20139) Signed-off-by: Wenchen Fan <[email protected]>
cloud-fan
pushed a commit
that referenced
this pull request
Jan 7, 2026
…StoreScalaSerializer ### What changes were proposed in this pull request? Along the same lines as #52049, apply the same fix to `KVStoreScalaSerializer` as well. ### Why are the changes needed? The previous fix in #52049 only removed the Jackson JSON string length limit in `JsonProtocol`, which covered Spark event <=> JSON SerDe. However, the exact same problem exists in `KVStoreScalaSerializer` as well, which is triggered when SHS is configured to use LevelDB/RocksDB KVStores. Example call chain that triggers the issue: ``` ExecutionPage.render() → sqlStore.planGraph(executionId, version) → store.read(classOf[SparkPlanGraphWrapper], ...) → KVStoreSerializer.deserialize() → mapper.readValue() // ← FAILS HERE with 20MB limit ``` ### Does this PR introduce _any_ user-facing change? Yes, users won't hit the Jackson JSON string length limit any more when using SHS. ### How was this patch tested? Manually tested with a SQL workload that had an intentionally long string for the plan graph. The fix mechanism itself is tested by previous PRs #49163 and #52049, this is just applying the same fix to SHS as well. ### Was this patch authored or co-authored using generative AI tooling? No Closes #53711 from rednaxelafx/fix-jackson-strlenlimit-kvstore. Authored-by: Kris Mok <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit ed20139) Signed-off-by: Wenchen Fan <[email protected]>
cloud-fan
pushed a commit
that referenced
this pull request
Jan 7, 2026
…StoreScalaSerializer ### What changes were proposed in this pull request? Along the same lines as #52049, apply the same fix to `KVStoreScalaSerializer` as well. ### Why are the changes needed? The previous fix in #52049 only removed the Jackson JSON string length limit in `JsonProtocol`, which covered Spark event <=> JSON SerDe. However, the exact same problem exists in `KVStoreScalaSerializer` as well, which is triggered when SHS is configured to use LevelDB/RocksDB KVStores. Example call chain that triggers the issue: ``` ExecutionPage.render() → sqlStore.planGraph(executionId, version) → store.read(classOf[SparkPlanGraphWrapper], ...) → KVStoreSerializer.deserialize() → mapper.readValue() // ← FAILS HERE with 20MB limit ``` ### Does this PR introduce _any_ user-facing change? Yes, users won't hit the Jackson JSON string length limit any more when using SHS. ### How was this patch tested? Manually tested with a SQL workload that had an intentionally long string for the plan graph. The fix mechanism itself is tested by previous PRs #49163 and #52049, this is just applying the same fix to SHS as well. ### Was this patch authored or co-authored using generative AI tooling? No Closes #53711 from rednaxelafx/fix-jackson-strlenlimit-kvstore. Authored-by: Kris Mok <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit ed20139) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Along the same lines as #52049, apply the same fix to
KVStoreScalaSerializeras well.Why are the changes needed?
The previous fix in #52049 only removed the Jackson JSON string length limit in
JsonProtocol, which covered Spark event <=> JSON SerDe.However, the exact same problem exists in
KVStoreScalaSerializeras well, which is triggered when SHS is configured to use LevelDB/RocksDB KVStores.Example call chain that triggers the issue:
Does this PR introduce any user-facing change?
Yes, users won't hit the Jackson JSON string length limit any more when using SHS.
How was this patch tested?
Manually tested with a SQL workload that had an intentionally long string for the plan graph.
The fix mechanism itself is tested by previous PRs #49163 and #52049, this is just applying the same fix to SHS as well.
Was this patch authored or co-authored using generative AI tooling?
No