[Improve] Improve login authentication #4273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g/apache/streampark/console/system/authentication/JWTUtil.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTUtil.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTUtil.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTUtil.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTUtil.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTUtil.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTUtil.java Co-authored-by: Copilot <[email protected]>
|
wolfboys
changed the title
omkarparth
reviewed
Aug 1, 2025
streampark-console/streampark-console-service/src/main/assembly/bin/streampark.sh
Outdated
Show resolved
Hide resolved
omkarparth
reviewed
Aug 1, 2025
...ark-console-service/src/main/java/org/apache/streampark/console/base/util/BashJavaUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR improves JWT authentication by consolidating encryption/decryption functionality and enhancing security. The changes include migrating from EncryptUtils to JWT-specific utilities and implementing secure key management.
- Consolidates JWT encryption/decryption logic into
JWTUtilclass - Introduces secure JWT key generation and management through
JWTSecretclass - Updates authentication flow to use consistent JWT verification approach
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| JWTUtil.java | Added AES-GCM encryption/decryption methods and unified JWT verification logic |
| JWTSecret.java | New class for secure JWT key generation, storage, and management |
| ShiroRealm.java | Updated authentication flow to use new JWT utilities and improved error messages |
| JWTFilter.java | Replaced EncryptUtils with JWTUtil for token decryption |
| Test files | Updated test cases to use new JWT utilities instead of EncryptUtils |
| BashJavaUtils.java | Minor formatting change (added blank line) |
...ole-service/src/main/java/org/apache/streampark/console/system/authentication/JWTSecret.java
Outdated
Show resolved
Hide resolved
...ole-service/src/main/java/org/apache/streampark/console/system/authentication/JWTSecret.java
Outdated
Show resolved
Hide resolved
...ole-service/src/main/java/org/apache/streampark/console/system/authentication/JWTSecret.java
Outdated
Show resolved
Hide resolved
...ole-service/src/main/java/org/apache/streampark/console/system/authentication/JWTSecret.java
Outdated
Show resolved
Hide resolved
...ole-service/src/main/java/org/apache/streampark/console/system/authentication/JWTSecret.java
Outdated
Show resolved
Hide resolved
...ole-service/src/main/java/org/apache/streampark/console/system/authentication/JWTSecret.java
Outdated
Show resolved
Hide resolved
...nsole-service/src/main/java/org/apache/streampark/console/system/authentication/JWTUtil.java
Outdated
Show resolved
Hide resolved
...nsole-service/src/main/java/org/apache/streampark/console/system/authentication/JWTUtil.java
Show resolved
Hide resolved
…g/apache/streampark/console/system/authentication/JWTSecret.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTSecret.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTSecret.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTUtil.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTSecret.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTSecret.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTSecret.java Co-authored-by: Copilot <[email protected]>
…g/apache/streampark/console/system/authentication/JWTUtil.java Co-authored-by: Copilot <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
Issue Number: close #xxx
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts