WW-5602 Fix StreamResult contentCharSet handling and refactor for extensibility #1510
+360
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Evaluate contentCharSet expression before checking for emptiness - Use StringUtils.isEmpty() for null/empty check on parsed value - Call setCharacterEncoding(null) to clear Dispatcher's default encoding - Set charset via setCharacterEncoding() instead of appending to content-type - Add test for expression evaluating to null Closes WW-5602 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add constants: DEFAULT_BUFFER_SIZE, DEFAULT_CONTENT_TYPE, DEFAULT_CONTENT_DISPOSITION, DEFAULT_INPUT_NAME - Extract resolveInputStream() for custom stream sources - Extract applyResponseHeaders() for custom header handling - Extract applyContentLength() for custom length calculation - Extract streamContent() for custom streaming behavior - Use try-with-resources for cleaner resource management - Add JavaDoc explaining extensibility of each method All extracted methods are protected to enable easy extension by users creating custom streaming result types. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Cast null to String to disambiguate between overloaded methods: - setCharacterEncoding(String) - setCharacterEncoding(Charset) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
lukaszlenart
requested review from
aleksandr-m,
cnenning,
jogep,
kusalk,
rgielen,
sdutry and
yasserzamani
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
contentCharSetis an expression that evaluates to null, the content-type header was incorrectly appending;charset=with no valueStreamResultto improve extensibility and code qualityChanges
Bug Fix (WW-5602)
contentCharSetexpression before checking for emptinesssetCharacterEncoding(null)to clear Dispatcher's default UTF-8 encoding when no charset is specifiedRefactoring
DEFAULT_BUFFER_SIZE,DEFAULT_CONTENT_TYPE,DEFAULT_CONTENT_DISPOSITION,DEFAULT_INPUT_NAMEprotectedmethods for easy extension:resolveInputStream()- custom stream sources (database, cloud, generated)applyResponseHeaders()- custom headers (ETag, X-Custom)applyContentLength()- custom length calculationstreamContent()- custom buffering, compression, encryptionTest plan
StreamResultTesttests passtestStreamResultWithNullCharSetExpressionverifies the bug fixCloses WW-5602
🤖 Generated with Claude Code