Skip to content

Commit e1a03a8

Browse files
fix(dashboard): improve JSON editor sizing without wrapper
1 parent 4192515 commit e1a03a8

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

superset-frontend/src/components/Modal/StandardModal.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ interface StandardModalProps {
4141
maskClosable?: boolean;
4242
wrapProps?: object;
4343
contentLoading?: boolean;
44-
resizable?: boolean;
45-
draggable?: boolean;
4644
}
4745

4846
// Standard modal widths
@@ -118,7 +116,6 @@ export function StandardModal({
118116
wrapProps,
119117
contentLoading = false,
120118
resizable = false,
121-
draggable = false,
122119
}: StandardModalProps) {
123120
const primaryButtonName = saveText || (isEditMode ? t('Save') : t('Add'));
124121

@@ -145,8 +142,6 @@ export function StandardModal({
145142
)
146143
}
147144
$resizable={resizable}
148-
resizable={resizable}
149-
draggable={draggable}
150145
>
151146
{contentLoading ? (
152147
<Flex justify="center" align="center" style={{ minHeight: 200 }}>

superset-frontend/src/dashboard/components/PropertiesModal/sections/AdvancedSection.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ const AdvancedSection = ({
7575
}
7676
bottomSpacing={false}
7777
>
78-
<div style={{ minHeight: 300, height: '60vh' }}>
7978
<StyledEditorHost
8079
id="dashboard-json-metadata"
8180
data-test="dashboard-metadata-editor"
@@ -85,10 +84,10 @@ const AdvancedSection = ({
8584
tabSize={2}
8685
wordWrap
8786
width="100%"
88-
height="100%"
87+
height="60vh"
88+
style={{ minHeight: 300 }}
8989
annotations={toEditorAnnotations(jsonAnnotations)}
9090
/>
91-
</div>
9291
</ModalFormField>
9392
);
9493

0 commit comments

Comments
 (0)