fix(Dashboard): Auto-apply filters with default values when extraForm… #36927

geido · 2026-01-06T17:11:07Z

SUMMARY

Fixes an issue where dashboard filters with default values were not automatically applied on dashboard load when extraFormData was set to empty. Previously, filters would show default values selected but require users to manually click the Apply button. The fix automatically applies filters when they have default values but empty extraFormData, ensuring charts load with filters applied from the start.

AFTER

531449025-2a09ba78-5d55-44e9-992e-69914e15dd43.mp4

TESTING INSTRUCTIONS

Create a dashboard.
Add filters to it. Set default values for the filters.
Manually edit the dashboard config to set the extraFormData value to empty.
Reopen the dashboard.
The dashboard loads with the default filter values properly applied.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codeant-ai-for-open-source · 2026-01-06T17:11:13Z

CodeAnt AI is reviewing your PR.

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

netlify · 2026-01-06T17:11:14Z

✅ Deploy Preview for superset-docs-preview canceled.

Name	Link
🔨 Latest commit	`d14e068`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/695d422f0b6bdb00086e13df

bito-code-review · 2026-01-06T17:11:17Z

Code Review Agent Run #e29eb6

Actionable Suggestions - 0

Additional Suggestions - 1

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx - 1
- Test assertion missing · Line 355-410
  
  The test 'auto-applies filter when extraFormData is empty in applied state' sets up a spy on updateDataMask but doesn't assert it's called. The auto-apply logic requires appliedDataMask to have value with empty extraFormData and incoming dataMask to have non-empty extraFormData, but here both have empty extraFormData, so updateDataMask won't be called. This means the test doesn't verify the auto-apply behavior as named.

Review Details

Files reviewed - 3 · Commit Range: d14e068..d14e068
- superset-frontend/src/dashboard/components/FiltersBadge/index.tsx
- superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx
- superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

codeant-ai-for-open-source · 2026-01-06T17:14:21Z

Nitpicks 🔍

🔒 No security issues identified
⚡ Recommended areas for review Changed status-condition semantics The new condition makes `shouldRecalculate` true whenever `prevChartStatus !== 'success'`, independent of whether any meaningful chart/filter state changed. This is different from the previous control flow (where recalculation only happened when `prevChartStatus !== 'success'` AND one of the comparisons changed). Verify this is intentional — it can cause extra work or incorrect indicator updates. Redundant dispatch risk The new auto-apply logic dispatches updateDataMask when `needsAutoApply` is true. If `appliedDataMask` and the incoming `dataMask` are deeply equal this dispatch is redundant and may trigger unnecessary re-renders, url updates, or network activity. Confirm a deep-equality check is performed before dispatching to avoid extra work or update loops. Reference vs deep equality The new effect uses reference equality (e.g., `dataMask !== prevDataMask`, `nativeFilters !== prevNativeFilters`, `chartLayoutItems !== prevChartLayoutItems`) to decide when to recalculate indicators. Complex objects are often recreated even when semantically equal which can cause unnecessary recalculations, or conversely, deep changes masked by stable references could be missed. Consider using a deep-equality check for these objects or a more targeted change detector. Missing assertion The new test "auto-applies filter when extraFormData is empty in applied state" creates a spy on `updateDataMask` but never asserts it was called. The test advances timers and only checks UI presence, so it can pass without actually verifying the intended auto-apply behavior. Add explicit assertions to ensure the auto-apply side effect happened. Potential side effects from spying original action The test uses `jest.spyOn(dataMaskActions, 'updateDataMask')` without mocking the implementation. If `updateDataMask` triggers real dispatches or other side effects, the test may become flaky or impact global state. Consider mocking the implementation to a no-op action object or safe stub to isolate the unit test.

codeant-ai-for-open-source · 2026-01-06T17:16:49Z

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx

        const isFirstTimeInitialization =
          !initializedFilters.has(filter.id) &&
-          dataMaskSelectedRef.current[filter.id]?.filterState?.value ===
-            undefined;
+          existingDataMask?.filterState?.value === undefined;


Suggestion: The isFirstTimeInitialization flag currently also depends on existingDataMask?.filterState?.value === undefined, which means that if a filter ever gets a value in dataMaskSelected before it has been marked as initialized (for example via a default/permalink value without extraFormData), it will permanently stop being treated as "first time" and required-first auto-apply logic may never fire even though initializedFilters was never updated; using only the explicit initializedFilters tracking avoids this inconsistent state. [logic error]

Severity Level: Minor ⚠️

Suggested change

const isFirstTimeInitialization =

!initializedFilters.has(filter.id) &&

dataMaskSelectedRef.current[filter.id]?.filterState?.value ===

undefined;

existingDataMask?.filterState?.value === undefined;

const isFirstTimeInitialization = !initializedFilters.has(filter.id);

Why it matters? ⭐

The current check couples "first-time" to the presence of an existing value in the selected mask. That can create a surprising state where a filter receives a value (e.g. from permalink/default) before initializedFilters is ever updated, which makes isFirstTimeInitialization false even though we never actually marked this filter as initialized. For requiredFirst handling we only care whether the filter was recorded in initializedFilters; using the explicit flag (!initializedFilters.has(filter.id)) is a clearer and more robust signal and will restore expected required-first auto-apply behavior. This is a functional fix, not just a cosmetic change.

Prompt for AI Agent 🤖

This is a comment left during a code review. **Path:** superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx **Line:** 209:211 **Comment:** *Logic Error: The `isFirstTimeInitialization` flag currently also depends on `existingDataMask?.filterState?.value === undefined`, which means that if a filter ever gets a value in `dataMaskSelected` before it has been marked as initialized (for example via a default/permalink value without `extraFormData`), it will permanently stop being treated as "first time" and required-first auto-apply logic may never fire even though `initializedFilters` was never updated; using only the explicit `initializedFilters` tracking avoids this inconsistent state. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.

This seems relevant?

codeant-ai-for-open-source · 2026-01-06T17:16:55Z

CodeAnt AI finished reviewing your PR.

msyavuz

There's the bot comment about permalinks that might need checking. Otherwise LGTM

…Data is empty

codeant-ai-for-open-source · 2026-01-07T11:14:33Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

github-actions · 2026-01-07T11:15:19Z

🎪 Showtime is building environment on GHA for 23c5ad6

github-actions · 2026-01-07T11:31:45Z

🎪 Showtime deployed environment on GHA for 23c5ad6

• Environment: http://54.244.145.45:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

bito-code-review

Code Review Agent Run #a0652c

Actionable Suggestions - 1

superset-frontend/src/dashboard/components/FiltersBadge/index.tsx - 1
- Logic Error in useEffect · Line 204-227

Additional Suggestions - 1

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx - 1
- Missing test assertion · Line 355-410
  
  The test 'auto-applies filter when extraFormData is empty in applied state' sets up a spy on `updateDataMask` but lacks an assertion to confirm the auto-apply behavior. Without checking if the spy was invoked, the test doesn't validate the claimed functionality and could pass incorrectly. Consider adding an expect statement to assert the call, or clarify if the test intent is only rendering verification.

Review Details

Files reviewed - 3 · Commit Range: 23c5ad6..23c5ad6
- superset-frontend/src/dashboard/components/FiltersBadge/index.tsx
- superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx
- superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-01-07T12:25:02Z

superset-frontend/src/dashboard/components/FiltersBadge/index.tsx

+    const shouldRecalculate =
+      prevChartStatus !== 'success' ||
+      dataMask !== prevDataMask ||
+      chart?.queriesResponse?.[0]?.rejected_filters !==
+        prevChart?.queriesResponse?.[0]?.rejected_filters ||
+      chart?.queriesResponse?.[0]?.applied_filters !==
+        prevChart?.queriesResponse?.[0]?.applied_filters ||
+      nativeFilters !== prevNativeFilters ||
+      chartLayoutItems !== prevChartLayoutItems ||
+      prevChartConfig !== chartConfiguration;
+
+    if (shouldRecalculate) {
+      const newIndicators = selectNativeIndicatorsForChart(
+        nativeFilters,
+        dataMask,
+        chartId,
+        chart,
+        chartLayoutItems,
+        chartConfiguration,
+      );
+      setNativeIndicators(newIndicators);
+    } else if (!showIndicators && nativeIndicators.length > 0) {
      setNativeIndicators(indicatorsInitialState);
-    } else if (prevChartStatus !== 'success') {
-      if (
-        chart?.queriesResponse?.[0]?.rejected_filters !==
-          prevChart?.queriesResponse?.[0]?.rejected_filters ||
-        chart?.queriesResponse?.[0]?.applied_filters !==
-          prevChart?.queriesResponse?.[0]?.applied_filters ||
-        nativeFilters !== prevNativeFilters ||
-        chartLayoutItems !== prevChartLayoutItems ||
-        dataMask !== prevDataMask ||
-        prevChartConfig !== chartConfiguration
-      ) {
-        setNativeIndicators(
-          selectNativeIndicatorsForChart(
-            nativeFilters,
-            dataMask,
-            chartId,
-            chart,
-            chartLayoutItems,
-            chartConfiguration,
-          ),
-        );
-      }
    }


Logic Error in useEffect

The reset logic for nativeIndicators when showIndicators is false should take precedence over recalculating. Currently, if shouldRecalculate evaluates to true but showIndicators is false, the code will set new indicators instead of resetting them, leading to incorrect state where indicators are shown when they shouldn't be.

Code Review Run #a0652c

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

Yes, avoid them

pull-request-size bot added the size/L label Jan 6, 2026

dosubot bot added the dashboard:native-filters Related to the native filters of the Dashboard label Jan 6, 2026

codeant-ai-for-open-source bot reviewed Jan 6, 2026

View reviewed changes

msyavuz reviewed Jan 7, 2026

View reviewed changes

fix(Dashboard): Auto-apply filters with default values when extraForm…

23c5ad6

…Data is empty

geido force-pushed the geido/fix/fitlers-auto-apply branch from d14e068 to 23c5ad6 Compare January 7, 2026 11:14

geido added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Jan 7, 2026

bito-code-review bot reviewed Jan 7, 2026

View reviewed changes

fix(Dashboard): Auto-apply filters with default values when extraForm… #36927

Are you sure you want to change the base?

fix(Dashboard): Auto-apply filters with default values when extraForm… #36927

Conversation

geido commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

AFTER

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

codeant-ai-for-open-source bot commented Jan 6, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

netlify bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for superset-docs-preview canceled.

Uh oh!

bito-code-review bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #e29eb6

Uh oh!

codeant-ai-for-open-source bot commented Jan 6, 2026

Nitpicks 🔍

Uh oh!

codeant-ai-for-open-source bot Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

msyavuz Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

codeant-ai-for-open-source bot commented Jan 6, 2026

Uh oh!

msyavuz left a comment

Choose a reason for hiding this comment

Uh oh!

codeant-ai-for-open-source bot commented Jan 7, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

bito-code-review bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Code Review Agent Run #a0652c

Uh oh!

bito-code-review bot Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

geido commented Jan 6, 2026 •

edited

Loading

netlify bot commented Jan 6, 2026 •

edited

Loading

bito-code-review bot commented Jan 6, 2026 •

edited

Loading

bito-code-review bot left a comment •

edited

Loading