fix(explore): hide inactive result tables in mixed chart view as table#37777
fix(explore): hide inactive result tables in mixed chart view as table#37777KH-Coder865 wants to merge 3 commits intoapache:masterfrom
Conversation
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #1ba5c9
Actionable Suggestions - 1
-
superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx - 1
- State Loss on Tab Switch · Line 202-205
Review Details
-
Files reviewed - 1 · Commit Range:
b74cf7e..39caa8d- superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx
Show resolved
Hide resolved
Code Review Agent Run #78c2c7Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Make isVisible optional to allow parent tab management.
Code Review Agent Run #0c0895Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following: pip3 install -r requirements/development.txt Alternatively it is possible to run pre-commit by running pre-commit manually: pre-commit run --all-files |
2 participants
SUMMARY
This PR fixes a frontend issue in the Mixed chart “View as table” modal where multiple result tables remain visible when switching between tabs.
For mixed charts, multiple result panes (Results, Results 2, etc.) are rendered, but inactive panes were not being unmounted when the active tab changed. This caused previously rendered tables to remain visible and overlap in the UI.
The fix conditionally renders each tab’s content based on the active tab key, ensuring that only the selected tab’s table is visible at any time.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: Switching between result tabs causes multiple tables to remain visible simultaneously.
After: Only the active tab’s table is rendered and visible.
TESTING INSTRUCTIONS
FIXES
ADDITIONAL INFORMATION
LABELS
viz:charts:table