Conversation
| @@ -0,0 +1,69 @@ | |||
| /** | |||
There was a problem hiding this comment.
This should be part of the plugin.
| import BigNumberTotal from './BigNumberTotal'; | ||
| import BoxPlot from './BoxPlot'; | ||
| import Bubble from './Bubble'; | ||
| import EchartsScatter from './EchartsScatter'; |
There was a problem hiding this comment.
This file is outdated. This is not necessary anymore.
| return self.nest_values(levels) | ||
|
|
||
|
|
||
| class EchartsScatter(BubbleViz): |
There was a problem hiding this comment.
Could you use the new api instead?
There was a problem hiding this comment.
@kristw is there already a working plan for migrating some of the more complex legacy viz's to the new api, namely the ones that rely on Pandas functionality? Is the plan to do that logic in JS, och making the heavy lifting in the backend? I anticipate quite a bit of work there, and can lend a hand if necessary, especially if the new API needs new functionality..
There was a problem hiding this comment.
We had light discussions about listing postprocessing operations as a new field in the api/v1/query parameters to call those pandas functionality in addition to the simple table query that it already support, but none had the cycle to draft the API spec nor work on it yet. If you would like to step in, that could be helpful.
I was thinking something along the line of
const queryFormData = {
group_by,
adhoc_filters,
...etc.
// Add a new field that takes an array of post-processing operations
// which we could enforce the schema in typescript
// then you need to modify /api/v1/query in python to handle it.
postProcessing = [ { operation: '', options: {...} } ];
}See superset-ui/query for current QueryFormData schema.
There was a problem hiding this comment.
Sounds reasonable. In all, I think this will be a big feature to implement, but can probably be dissected into smaller parts. I would probably start with implementing the pivot operation, as it is used quite frequently in viz's and should be easy to start with. I'm fairly overloaded with other stuff right now, but should be able to look into this in a few weeks time if nobody wants to take the lead.
There was a problem hiding this comment.
Has anyone looked at this? Not sure if it is suitable here https://github.com/nickslevine/zebras
There was a problem hiding this comment.
It also doesn't have to be either done in the frontend or backend; can be both. Some postprocessing can be very expensive to move to the front, especially percentiles/quantiles and the like that require having a full distribution, so those would be preferable to perform in the backend, while others might be well suited for the frontend. So I think being able to offer at least some postprocessing options in the backend would be nice, leaving it up to the viz plugin developer to decide where to perform the calculations.
|
Thanks for the early attention to this draft, this is my very first attempt at using the visualization plugins and was excited to get something half working fairly quickly. Planning on using the latest |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
|
anybody who has succeeded add echarts in superset ? please shared a sample for us , thanks . I have searched in network but most information of it is about 0.28 . Hardly any informations about 0.34 |
|
@fengye712 this proof of concept pretty much does that, there might be a bit more work to do, but I had things running here. FYI this works along with: apache-superset/superset-ui-plugins#202 |
|
i have meet some problem when follow the step |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
7 participants
CATEGORY
Choose one
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS