[SYSTEMDS-3696] Fix incSliceLine flag for pruning strategies

mboehm7 · mboehm7 · commit 827438b953ed · 2024-09-30T09:31:10.000+02:00
Recent experiments revealed that even with disabled pruning strategies
incSliceLine was still faster than sliceLine on some datasets because
the reevaluated top-K set was passed to the current top-K set from the
beginning and thus used for additional score pruning. We now prevent
this if score pruning is disabled.
diff --git a/scripts/builtin/incSliceLine.dml b/scripts/builtin/incSliceLine.dml
@@ -180,7 +180,7 @@ m_incSliceLine = function(
   prevTK2 = matrix(0, 0, ncol(X2));
   prevTKC2 = matrix(0, 0, 4);
   minsc = -Inf
-  if( nrow(prevTK) > 0 ) {
+  if( nrow(prevTK) > 0 & enableIncScorePruning ) {
     prevTK2 = oneHotEncodeUsingOffsets(prevTK, foffb, foffe);
     [minsc, prevTKC2] = computeLowestPrevTK(prevTK2, X2, totalE, eAvg, alpha)
   }

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ m_incSliceLine = function(`
`180`	`180`	`prevTK2 = matrix(0, 0, ncol(X2));`
`181`	`181`	`prevTKC2 = matrix(0, 0, 4);`
`182`	`182`	`minsc = -Inf`
`183`		`- if( nrow(prevTK) > 0 ) {`
	`183`	`+ if( nrow(prevTK) > 0 & enableIncScorePruning ) {`
`184`	`184`	`prevTK2 = oneHotEncodeUsingOffsets(prevTK, foffb, foffe);`
`185`	`185`	`[minsc, prevTKC2] = computeLowestPrevTK(prevTK2, X2, totalE, eAvg, alpha)`
`186`	`186`	`}`