[MINOR] Exclude Scuro if dependencies not installed #2150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I like it, to make it even better can we make the requirements open ended, such that if someone has newer versions installed it is also valid? |
Contributor
Author
Sure, that's why I check if the installed version is |
Baunsgaard
reviewed
Dec 4, 2024
|
|
||
| def check_package_version(package_name, required_version): | ||
| try: | ||
| return version(package_name) >= required_version |
Contributor
There was a problem hiding this comment.
i see, missed it was greater than,
LGTM
Contributor
|
Thanks for the commit, It is now merged. |
fietenoer
pushed a commit
to fietenoer/systemds
that referenced
this pull request
Dec 5, 2024
This commits refine the __init__.py file for systemds, to conditionally load the Scuro library. Previeously, more packages would have to be installed to run SystemDS via the Python API. Now it is more lean with an informative warning listing the required packages if Scuro is required. Closes apache#2150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch checks if the dependent packages for Scuro including their correct versions are installed and otherwise skips importing Scuro.