[SYSTEMDS-3701] Rework Modality Data Structure #2155
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@christinadionysio thanks for the patch - could you please have a look into the failing python test? Recently, ubuntu-latest switched to Ubuntu 24 which also updated a number of dependencies and hence we moved to Python 3.8 (which might have affected some of these issues). |
Contributor
|
LGTM - thanks for the modifications @christinadionysio. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch disentangles the loading mechanisms of raw data from the representations and contains rewrites of the Modality data structure. It adds a base loader that can be extended for every modality type and needs to be adapted according to the file structure of the raw data. Additionally, the modality data structure was reworked to enable stacking of operations. This includes slight API changes and the introduction of
.apply_representation()and.combine()methods. Individual modality types are replaced by a universalUnimodalModalitythat takes aModalityTypeto indicate the original modality of the data.