[MINOR] Increase Memory Estimate for Frames#2158
Closed
Baunsgaard wants to merge 2 commits intoapache:mainfrom
Closed
[MINOR] Increase Memory Estimate for Frames#2158Baunsgaard wants to merge 2 commits intoapache:mainfrom
Baunsgaard wants to merge 2 commits intoapache:mainfrom
Conversation
This commit increases the default estimate of frame size. Previously, frames were estimated similarly to Matrices. The wrong estimate leads to problems on frames of > Integer rows. To improve it, this commit defaults to 8 character strings on all cells. In an unread matrix. Since there is no way of knowing if the input Frame contains longer strings, it is still a subpar estimate. However, it is an improvement overestimating everything as a dense double Matrix. (The change happened because I encountered very incorrect estimates in BEWARE)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2158 +/- ##
============================================
- Coverage 72.06% 72.06% -0.01%
- Complexity 43964 43972 +8
============================================
Files 1443 1443
Lines 166239 166246 +7
Branches 32453 32455 +2
============================================
+ Hits 119797 119798 +1
- Misses 37182 37194 +12
+ Partials 9260 9254 -6 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit increases the default estimate of frame size. Previously, frames were estimated similarly to Matrices. The wrong estimate leads to problems on frames of > Integer rows. To improve it, this commit defaults to 8 character strings on all cells. In an unread matrix.
Since there is no way of knowing if the input Frame contains longer strings, it is still a subpar estimate. However,
it is an improvement overestimating everything as a dense double Matrix.
(The change happened because I encountered very incorrect estimates in BEWARE)