[SYSTEMDS-3823] Compression test case for bultin kmeans#2194
Closed
e-strauss wants to merge 1 commit intoapache:mainfrom
Closed
[SYSTEMDS-3823] Compression test case for bultin kmeans#2194e-strauss wants to merge 1 commit intoapache:mainfrom
e-strauss wants to merge 1 commit intoapache:mainfrom
Conversation
Added missing decompression handling for indexed MatrixBlock copy
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2194 +/- ##
============================================
+ Coverage 71.86% 72.30% +0.43%
- Complexity 44707 44997 +290
============================================
Files 1450 1452 +2
Lines 169272 169309 +37
Branches 32996 33037 +41
============================================
+ Hits 121652 122413 +761
+ Misses 38290 37587 -703
+ Partials 9330 9309 -21 ☔ View full report in Codecov by Sentry. |
Baunsgaard
reviewed
Jan 29, 2025
Contributor
Baunsgaard
left a comment
Baunsgaard
left a comment
There was a problem hiding this comment.
LGTM, just two lines to change.
| */ | ||
| public void copy(int rl, int ru, int cl, int cu, MatrixBlock src, boolean awareDestNZ ) { | ||
| if (src instanceof CompressedMatrixBlock){ | ||
| src = ((CompressedMatrixBlock) src).decompress(); |
Contributor
There was a problem hiding this comment.
add a string to the decompress command to indicate what is causing the decompression.
| .getCPHeavyHitterCount("compress") : Statistics.getCPHeavyHitterCount("sp_compress"); | ||
|
|
||
| Assert.assertEquals("Assert that the compression counts expeted matches actual: " + compressionCount + " vs " | ||
| System.out.println(actualCompressionCount); |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix adds a new test case for the builtin kmeans with compression enabled. It also adds a missing decompression handling for indexed MatrixBlock copy, which previously broke the compressed kmeans test case.