implement new colProd and rowProd tests#2234
Closed
Twolvero wants to merge 6 commits intoapache:mainfrom
Closed
Conversation
make tests runnable test rowProd and colPord add operators to test implement denseColProd and denseRowProd. Sparsity not yet fully implemented and tested set PROD as supported ROW and COL aggregation functions so that hops and lops can be turned into SpoofFused operators correct function fix lnnz value new test matrix input minor adjustments new test types delete todo fix executeSparseColRowProd() debug executeSparseColRowProd() performance improvement colProd change fix transpose in tests lnnz fix new tests rewrite to a more readable code thorough test make tests readable final adjustments and debugging
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2234 +/- ##
============================================
- Coverage 72.46% 72.44% -0.03%
- Complexity 45453 45480 +27
============================================
Files 1469 1469
Lines 170893 171020 +127
Branches 33325 33386 +61
============================================
+ Hits 123846 123900 +54
- Misses 37630 37687 +57
- Partials 9417 9433 +16 ☔ View full report in Codecov by Sentry. |
Contributor
|
LGTM - thanks for the extended and new tests @Frxms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.