Improve test coverage for rewrite package#2240
Improve test coverage for rewrite package#2240ReneEnjilian wants to merge 16 commits intoapache:mainfrom
Conversation
|
Thanks @ReneEnjilian - could you please address the failing rewrite tests (I just kicked them off again, but there seem to be systematic failures). |
|
I implemented a fix and hope that this resolves the issue now. The error does not occur on my machine but from what I can see is that R struggled with the class type of the result matrix. Changing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2240 +/- ##
============================================
- Coverage 72.46% 72.46% -0.01%
- Complexity 45453 45462 +9
============================================
Files 1469 1469
Lines 170893 170893
Branches 33325 33325
============================================
- Hits 123846 123845 -1
- Misses 37630 37640 +10
+ Partials 9417 9408 -9 ☔ View full report in Codecov by Sentry. |
|
LGTM - thanks @ReneEnjilian for the effort improving our test coverage. |
This pull request is the first in a series aimed at enhancing the test coverage of the rewrite package. Specifically, it adds additional tests for the algebraic simplifications defined in
RewriteAlgebraicSimplificationStatic. The goal is also to proactively identify potential bugs, similar to our previous efforts. No bugs were found in this patch.