setup: fix toolchain installation error

[DemesneGH]

cargo --version is used to trigger the Rust toolchain installation but does not work currently and fails with the error:
"error: toolchain 'nightly-....'is not installed"
Use the rustup toolchain install instead.

[DemesneGH]

I see it's also fixed in OP-TEE build: OP-TEE/build#818

[DemesneGH]

Seems cloning OP-TEE repo failed: Cannot fetch firmware/SCP-firmware.git, could you help to check it out? @b49020 @jforissier

[b49020]

@DemesneGH could you retry again? seems like a network issue to me.

[jforissier]

The CI is broken in https://github.com/OP-TEE/optee_os too :-/
I can clone the OP-TEE repo locally with no issue but GitHub is getting a 502 error on https://git.gitlab.arm.com/firmware/SCP-firmware.git

$ mkdir /tmp/optee; cd /tmp/optee
$ repo init -u https://github.com/OP-TEE/manifest.git -m qemu_v8.xml
$ repo sync -j10
[...]
repo sync has finished successfully.
$ ls SCP-firmware/
arch           cmake           contrib          dco.txt   doc     framework  license.md      Makefile.cmake  product    requirements.txt  tools      user_guide.md
change_log.md  CMakeLists.txt  contributing.md  debugger  docker  interface  maintainers.md  module          readme.md  security.md       unit_test  Vagrantfile

If the problem persists we could create a mirror of SCP-firmware on a reliable host (i.e., GitHub) and use it instead.

[jforissier]

If the problem persists we could create a mirror of SCP-firmware on a reliable host (i.e., GitHub) and use it instead.

OP-TEE/manifest#314

[ivila]

I think we should notice that this command requires higher version of rustup.

With rustup 1.27.1 (54dd3d00f 2024-04-24):

With rustup 1.28.0 (6e19fbec7 2025-03-02)

According to this, developers can use rustup self update to update the version of rustup.

[ivila]

rustup 1.28.0 was released 2 days ago, I think most of the developers still keeps on rustup 1.27.1,

[DemesneGH]

How about change line32 to:
rustup self update && rustup uninstall stable && rustup install stable?

[ivila]

How about change line32 to: rustup self update && rustup uninstall stable && rustup install stable?

Good catch, it is better.

[DemesneGH]

done

[ivila]

Thanks for your fix, everything looks good to me, feel free to add: Reviewed-by: Zehui Chen <ivila@apache.org> 😄

[b49020]

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

[DemesneGH]

Merged, thanks!