Skip to content

Conversation

Ma77Ball
Copy link
Contributor

Purpose

This pull request adds support for toggling the property panel by double-clicking on an operator in the workflow editor. The goal is to improve usability by allowing users to quickly open or close the property panel without relying on other UI elements.

Changes

  • Subscribed to openPropertyPanelStream and closePropertyPanelStream in PropertyEditorComponent to handle panel visibility.
  • Imported PanelService into WorkflowEditorComponent and injected it via the constructor.
  • Added double-click logic in WorkflowEditorComponent to open or close the property panel based on isPanelOpen.
  • Introduced openPropertyPanelSubject and closePropertyPanelSubject streams in PanelService along with their corresponding methods and accessors.

Demo

double-click

@Ma77Ball Ma77Ball requested a review from bobbai00 April 14, 2025 03:34
@Ma77Ball Ma77Ball linked an issue Apr 14, 2025 that may be closed by this pull request
Copy link
Contributor

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. left a minor comment

this.wrapper.setMultiSelectMode(<boolean>event[1].shiftKey);
const elementID = event[0].model.id.toString();
if (this.workflowActionService.getTexeraGraph().hasOperator(elementID)) {
if (this.panelservice.isPanelOpen) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can merge this if-else block to a method called this.panelservice.togglePropertyPanel()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also make sure to use the name panelService (camel case)

@bobbai00 bobbai00 changed the title Double Click Property Window Functionality Double clicks on the operator will open the property panel Apr 16, 2025
@Yicong-Huang
Copy link
Contributor

@Ma77Ball please take care of the comments and work with @bobbai00 to finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend Misc. - Minimize and Unminimize Property Menu
4 participants