Skip to content

Conversation

seongjinyoon
Copy link
Contributor

Feature:

  • Deletion of selected links with keyboard
  • Right click on link to get drop down menu
  • Delete combination of operators, comment boxes, and links together
  • Modified Drop down menu for comment box as it included "run to this operator" despite not being an operator.

Closes #3579
Closes #3074

Screen.Recording.2025-08-06.at.1.47.40.PM.mov

@Copilot Copilot AI review requested due to automatic review settings August 6, 2025 21:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the deletion functionality for workflow editor links, adding support for keyboard deletion of selected links, right-click context menus for links, and unified deletion of operators, comment boxes, and links together.

  • Added right-click context menu support for links with highlighting functionality
  • Enhanced deletion logic to handle operators, comment boxes, and links in a single bundled action for proper undo/redo support
  • Modified context menu display logic to show appropriate options when links are selected

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
workflow-editor.component.ts Added link right-click event handling and enhanced deleteElements method to support unified deletion of all element types
context-menu.component.ts Added hasHighlightedLinks method and updated onDelete to handle combined deletion of operators, comment boxes, and links
context-menu.component.html Modified context menu visibility conditions to show appropriate options when links are highlighted

@Ma77Ball
Copy link
Contributor

Ma77Ball commented Aug 7, 2025

Using right-click to select and delete links is a helpful improvement over the original delete functionality, especially for quickly removing multiple links. However, since using right-click as a select for the delete action isn't a common pattern, it might be confusing for some users. It might be worth merging both our branches (#3602). This would allow us to keep the dedicated delete button on each link for clarity, while also supporting the right-click shortcut for more advanced users who want to delete multiple links quickly.

@Yicong-Huang Yicong-Huang changed the title feat(gui): Enhance Deleting Edges. feat(gui): Enhance Deleting Edges Aug 7, 2025
@aglinxinyuan aglinxinyuan self-requested a review August 9, 2025 03:29
@aglinxinyuan aglinxinyuan added the gui Changes related to the frontend GUI label Aug 9, 2025
Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aglinxinyuan aglinxinyuan enabled auto-merge (squash) August 9, 2025 03:30
@aglinxinyuan
Copy link
Contributor

Please fix the frontend test.

auto-merge was automatically disabled August 11, 2025 21:48

Head branch was pushed to by a user without write access

@aicam aicam merged commit 12849ac into apache:master Aug 11, 2025
10 checks passed
@seongjinyoon seongjinyoon deleted the feat/edge-delete branch August 11, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Changes related to the frontend GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the delete button for multiple edges Delete button is hard to use
4 participants