-
Notifications
You must be signed in to change notification settings - Fork 99
feat(gui): Enhance Deleting Edges #3636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the deletion functionality for workflow editor links, adding support for keyboard deletion of selected links, right-click context menus for links, and unified deletion of operators, comment boxes, and links together.
- Added right-click context menu support for links with highlighting functionality
- Enhanced deletion logic to handle operators, comment boxes, and links in a single bundled action for proper undo/redo support
- Modified context menu display logic to show appropriate options when links are selected
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
workflow-editor.component.ts | Added link right-click event handling and enhanced deleteElements method to support unified deletion of all element types |
context-menu.component.ts | Added hasHighlightedLinks method and updated onDelete to handle combined deletion of operators, comment boxes, and links |
context-menu.component.html | Modified context menu visibility conditions to show appropriate options when links are highlighted |
core/gui/src/app/workspace/component/workflow-editor/workflow-editor.component.ts
Show resolved
Hide resolved
...pp/workspace/component/workflow-editor/context-menu/context-menu/context-menu.component.html
Show resolved
Hide resolved
Using right-click to select and delete links is a helpful improvement over the original delete functionality, especially for quickly removing multiple links. However, since using right-click as a select for the delete action isn't a common pattern, it might be confusing for some users. It might be worth merging both our branches (#3602). This would allow us to keep the dedicated delete button on each link for clarity, while also supporting the right-click shortcut for more advanced users who want to delete multiple links quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please fix the frontend test. |
Head branch was pushed to by a user without write access
Feature:
Closes #3579
Closes #3074
Screen.Recording.2025-08-06.at.1.47.40.PM.mov