Skip to content

Update generated array style#3080

Merged
Jens-G merged 1 commit intoapache:masterfrom
kluever:patch-1
Jan 6, 2025
Merged

Update generated array style#3080
Jens-G merged 1 commit intoapache:masterfrom
kluever:patch-1

Conversation

@kluever
Copy link
Contributor

@kluever kluever commented Dec 29, 2024

C-style array declarations (e.g. Foo foos[]) is discouraged by the JLS. Java style (e.g., Foo[] foos) should be preferred.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

C-style array declarations (e.g. `Foo foos[]`) is discouraged by the JLS. Java style (e.g., `Foo[] foos`) should be preferred.
@Jens-G Jens-G added the java Pull requests that update Java code label Jan 6, 2025
@Jens-G Jens-G merged commit bb8cac5 into apache:master Jan 6, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants