Skip to content

Conversation

@mhlakhani
Copy link
Contributor

#3165 broke the build with c++11.

I split out the compile time fix from https://github.com/apache/thrift/pull/3167/files#diff-d8d7400cdf01511c2ad2df7caf958173c2e96e8633271709c9b0b5cd8e89215c to ensure we have a clean trunk (so I can have other changes on top). I can't take credit for the fixes.

I verified this compiles with gcc, clang (on c++11) and also on clang with c++1z

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@CJCombrink
Copy link
Contributor

Thanks, I am not sure what the holdup is on #3167
Nonetheless you will also need the change in "lib/cpp/src/thrift/transport/TSocketUtils.h" Same idea different file

@mhlakhani
Copy link
Contributor Author

thanks @CJCombrink ! I've pulled in those changes -- though I wasn't able to reproduce that build failure.

@Jens-G Jens-G added the c++ label Jul 28, 2025
@mhlakhani mhlakhani merged commit b0f2423 into apache:master Aug 2, 2025
20 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants