Error messages when server closes connection #12437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A server can close a connection while we're expecting a response. For example, the server may close the connection due to a keep-alive timeout. This results in a 502 response to the client. Log an error in this case, so that the administrator has a chance to adjust the keep-alive timeout on the ATS side to avoid this situation.
bneradt
requested changes
Aug 11, 2025
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
It would be good to have @bryancall look at this when he is back from PTO. I think we were considering moving away from error.log and transitioning content to diags.log.
That said, if that is not the case, I agree that these connection-level messages thematically fit error.log. If we're keeping error.log.
bneradt
requested changes
Aug 25, 2025
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks like we're OK with this from our PR/issue meeting. But let's include the origin URL.
bneradt
requested changes
Nov 25, 2025
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good. Thank you for adding the URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A server can close a connection while we're expecting a response. For example, the server may close the connection due to a keep-alive timeout. This results in a 502 response to the client. Log an error in this case, so that the administrator has a chance to adjust the keep-alive timeout on the ATS side to avoid this situation.