-
Notifications
You must be signed in to change notification settings - Fork 841
Add percentage weight to server_groups_list #12653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| a percentage key that determines how frequently that group is selected when multiple | ||
| entries are present. | ||
|
|
||
| Percentages are relative; they do not need to sum to 100. Any omitted percentage defaults to 100. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's a ratio then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe a weight as you say on the subject.
|
I'm not too sure if this is a good approach. groups_list is probably not the only setting that users would want to configure like this. And some of those may not be controllable on sni.yaml. I feel like making A/B test plugin is a better approach. I can't think of any reason to have the mechanism on ATS core. |
|
This is what I'm thinking. We'd need to introduce a new TS API to set group_list, but the idea is basically enabling plugins to do something on an SNI action. The difference from a global plugin that uses |
|
[approve ci autest 1] |
This adds the option to choose how often a server group is used in sni.