Replace deprecated ASN1_STRING_data function #12698
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: shukitchan <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes OpenSSL API usage in the WASM plugin by replacing a deprecated function with its recommended replacement, improving both safety and compatibility with newer OpenSSL versions.
Key Changes:
- Replaces deprecated
ASN1_STRING_datawithASN1_STRING_get0_datain certificate SAN name extraction - Updates pointer type from
char *toconst char *to preserve const-correctness
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the way SAN certificate names are extracted to improve safety and compatibility with newer OpenSSL APIs.
print_san_certificateinats_context.cc, replaces the deprecatedASN1_STRING_datawithASN1_STRING_get0_dataand updates the pointer type toconst char *for safer and more modern OpenSSL usage.