Fix request buffering with post_copy_size=0 #12702
Open
+90
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When proxy.config.http.request_buffer_enabled is set to 1 with proxy.config.http.post_copy_size set to 0, POST requests were failing. The fix disables request buffering when post_copy_size is 0, treating it as an indication to not buffer POST data. Fixes: apache#6900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When proxy.config.http.request_buffer_enabled is set to 1 with proxy.config.http.post_copy_size set to 0, POST requests were failing. The fix disables request buffering when post_copy_size is 0, treating it as an indication to not buffer POST data.
Fixes: #6900