11.x: regex_remap: Remove // prefix from host match string#12706
Closed
bneradt wants to merge 1 commit intoapache:11-Devfrom
Closed
11.x: regex_remap: Remove // prefix from host match string#12706bneradt wants to merge 1 commit intoapache:11-Devfrom
bneradt wants to merge 1 commit intoapache:11-Devfrom
Conversation
When the host option was enabled, regex_remap prepended '//' before the host in the match string, resulting in '//host/path' instead of 'host/path'. This was confusing because users associated the '//' with the 'http://' scheme, leading to double-slash issues when writing HTTP-to-HTTPS redirect rules. The match string now uses 'host/path' format. Documentation and tests have been updated accordingly, including new examples for host and method options. Fixes: apache#12691
cd88e89 to
baa76fc
Compare
Contributor
Author
|
@zwoop had the following comment to the mailing list thread: This is a good point. That being the case, I'm going to close this PR and replace it with a documentation update PR making sure this behavior is well explained: #12730 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the host option was enabled, regex_remap prepended '//' before the host in the match string, resulting in '//host/path' instead of 'host/path'. This was confusing because users associated the '//' with the 'http://' scheme, leading to double-slash issues when writing HTTP-to-HTTPS redirect rules. The match string now uses 'host/path' format. Documentation and tests have been updated accordingly, including new examples for host and method options.
Fixes: #12691
There was a dev mailing list email about this and no one complained about the change. Applying lazy consensus, I'm marking this PR as ready for review.