Fix crash logs: verify crash data was received #12785
Open
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
force-pushed
the
fix_crashlog_generation
branch
2 times, most recently
from
9edd4df to
49d8702
Compare
The poll() check from apache#12783 relied on POLLIN to detect crash data, but this is unreliable - on some systems poll() sets POLLIN for EOF (socket closed without data). This tweak adds reading on the socket to make sure that there is data being sent to verify that there was indeed a crash. This actually (as opposed to the previous patch) distinguishes a real crash (data written then pipe closed) from a normal exit (pipe just closed).
bneradt
force-pushed
the
fix_crashlog_generation
branch
from
49d8702 to
e6b9a62
Compare
bneradt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The poll() check from #12783 relied on POLLIN to detect crash data, but
this is unreliable - on some systems poll() sets POLLIN for EOF (socket
closed without data). This tweak adds reading on the socket to make sure
that there is data being sent to verify that there was indeed a crash.
This actually (as opposed to the previous patch) distinguishes a real
crash (data written then pipe closed) from a normal exit (pipe just
closed).