Skip to content

Revert "Disable the HttpSM half open logic if the underlying transpor… #6083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zwoop wants to merge 1 commit into from
Closed

Revert "Disable the HttpSM half open logic if the underlying transpor… #6083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions proxy/http/Http1ClientSession.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,6 @@ class Http1ClientSession : public ProxyClientSession
void do_io_shutdown(ShutdownHowTo_t howto) override;
void reenable(VIO *vio) override;

bool
allow_half_open()
{
// Only allow half open connections if the not over TLS
return (client_vc && dynamic_cast<SSLNetVConnection *>(client_vc) == nullptr);
}

void
set_half_close_flag(bool flag) override
{
Expand Down
7 changes: 1 addition & 6 deletions proxy/http/Http1ClientTransaction.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,5 @@ Http1ClientTransaction::transaction_done()
bool
Http1ClientTransaction::allow_half_open() const
{
bool config_allows_it = (current_reader) ? current_reader->t_state.txn_conf->allow_half_open > 0 : true;
if (config_allows_it) {
// Check with the session to make sure the underlying transport allows the half open scenario
return static_cast<Http1ClientSession *>(parent)->allow_half_open();
}
return false;
return current_reader ? current_reader->t_state.txn_conf->allow_half_open > 0 : true;
}