Skip to content

Conversation

@tlopex
Copy link
Member

@tlopex tlopex commented Nov 15, 2025

Summary

This PR reorganizes the conda-related files and removes unused conda build infrastructure.

Changes

Moved Files

  • conda/build-environment.yamltests/conda/build-environment.yaml
  • conda/condarctests/conda/condarc

Removed Files

  • conda/build_cpu.sh, conda/build_cuda.sh, conda/build_win.bat (build scripts)
  • conda/recipe/ (entire directory with conda package recipes)
  • conda/Dockerfile.template, conda/render_cuda_dockerfiles.py

Updated References

  • .github/actions/setup/action.yml - Updated paths to reference tests/conda/
  • tests/lint/blocklint.sh - Removed reference to deleted conda/recipe/meta.yaml
  • version.py - Removed conda recipe version sync logic
  • ci/scripts/jenkins/git_skip_ci_globs.py - Removed conda/* from skip globs
  • .github/CODEOWNERSHIP - Updated ownership path to tests/conda/**

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tlopex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's continuous integration and development environment by reorganizing existing Conda configuration files into a more appropriate tests/conda directory. Concurrently, it removes a substantial amount of obsolete Conda build infrastructure, including recipes, build scripts, and Docker-related files, which were no longer in use. These changes result in a cleaner, more maintainable codebase and ensure that all relevant CI configurations and tooling correctly reflect the new file locations and the absence of the deprecated build components.

Highlights

  • Conda Configuration Relocation: Conda configuration files, specifically build-environment.yaml and condarc, have been moved from the root conda/ directory to tests/conda/ to better reflect their testing-related purpose and consolidate test infrastructure.
  • Removal of Unused Conda Build Infrastructure: A significant amount of obsolete Conda build infrastructure has been removed. This includes the entire conda/recipe/ directory (containing various build scripts and metadata), standalone build scripts (build_cpu.sh, build_cuda.sh, build_win.bat), Dockerfile templates (Dockerfile.template), and a script for rendering CUDA Dockerfiles (render_cuda_dockerfiles.py). This cleanup targets components that were no longer in active use.
  • CI and Tooling Updates: Various CI workflows and development tools have been updated to reflect the file relocations and removals. This includes adjusting paths in GitHub Actions (.github/actions/setup/action.yml), removing references to deleted files in linting scripts (tests/lint/blocklint.sh), updating version synchronization logic (version.py), and modifying CI skip globs (ci/scripts/jenkins/git_skip_ci_globs.py). Code ownership rules (.github/CODEOWNERSHIP) were also updated to match the new structure.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a solid cleanup by reorganizing conda-related files and removing unused conda build infrastructure. The changes are consistent and well-executed. Moving the environment configuration to tests/conda is a logical improvement, and all references across the codebase, including CI workflows, ownership files, and scripts, have been updated accordingly. This refactoring enhances the project's maintainability by removing obsolete components. The changes are approved.

@tlopex
Copy link
Member Author

tlopex commented Nov 17, 2025

cc @tqchen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant