Skip to content

[CI] Update file patterns for specific linting hooks #18484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CI] Update file patterns for specific linting hooks #18484

wants to merge 1 commit into from
+14 −10

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Nov 21, 2025 •
edited
Loading

How

  • Updat file patterns for specific linting hooks to ensure they only run on relevant file types.

minor update

  • Fix linting commands to handle interactive and non-interactive modes
  • Add 'pre-commit' to default stages in .pre-commit-config.yaml.
  • Add inplace fix flags

@guan404ming guan404ming marked this pull request as ready for review November 21, 2025 11:50
@guan404ming
Copy link
Member Author

guan404ming commented Nov 21, 2025

cc @tqchen

cchung100m
cchung100m approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@cchung100m cchung100m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks to @guan404ming 😄

@guan404ming
Copy link
Member Author

guan404ming commented Nov 26, 2025

cc @tlopex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cchung100m cchung100m cchung100m approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guan404ming @cchung100m