-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[WIP][CI] Upgrade CI to Python 3.10 #18647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @mshr-h, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the continuous integration pipeline by upgrading the Python version used in the CI environment to 3.10. This involves adjusting the build configuration and updating the associated dependency specifications to ensure compatibility and leverage newer language features. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to upgrade the CI to Python 3.10 by updating the bootstrap script and its corresponding lockfiles. The changes are straightforward, but the newly generated constraints file constraints-3.10.txt has a duplicate entry for the pip package, which will cause installation failures. This seems to be caused by a flaw in the generate.sh script which appends dependencies that are already present. Additionally, many packages in constraints-3.10.txt are pinned to versions that do not appear to be publicly available on PyPI (e.g., certifi==2026.1.4, cffi==2.0.0). If this is unintentional, it will also lead to build failures.
| zipp==3.23.0 ; python_version >= "3.10" and python_version < "3.12" \ | ||
| --hash=sha256:071652d6115ed432f5ce1d34c336c0adfd6a884660d1e9712a256d3d3bd4b14e \ | ||
| --hash=sha256:a07157588a12518c9d4034df3fbbee09c814741a33ff63c05fa29d26a2404166 | ||
| pip==25.3 --hash=sha256:9655943313a94722b7774661c21049070f6bbb0a1516bf02f7c8d5d9201514cd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c44d37a to
30b7396
Compare
30b7396 to
ddb0b23
Compare
|
cc @yongwww |
Python 3.9 is EoL in 2025-10, so it's a good time to move to 3.10. Also, upgrade other dependencies.
refs: