Skip to content

Conversation

@mshr-h
Copy link
Contributor

@mshr-h mshr-h commented Jan 9, 2026

Python 3.9 is EoL in 2025-10, so it's a good time to move to 3.10. Also, upgrade other dependencies.

refs:

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mshr-h, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the continuous integration pipeline by upgrading the Python version used in the CI environment to 3.10. This involves adjusting the build configuration and updating the associated dependency specifications to ensure compatibility and leverage newer language features.

Highlights

  • CI Python Version Update: The CI bootstrapping script has been updated to specifically target Python 3.10, deprecating previous versions.
  • Dependency Management: New dependency constraint files for Python 3.10 have been introduced, while older constraint and requirement files for Python 3.7, 3.8, and 3.9 have been removed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to upgrade the CI to Python 3.10 by updating the bootstrap script and its corresponding lockfiles. The changes are straightforward, but the newly generated constraints file constraints-3.10.txt has a duplicate entry for the pip package, which will cause installation failures. This seems to be caused by a flaw in the generate.sh script which appends dependencies that are already present. Additionally, many packages in constraints-3.10.txt are pinned to versions that do not appear to be publicly available on PyPI (e.g., certifi==2026.1.4, cffi==2.0.0). If this is unintentional, it will also lead to build failures.

zipp==3.23.0 ; python_version >= "3.10" and python_version < "3.12" \
--hash=sha256:071652d6115ed432f5ce1d34c336c0adfd6a884660d1e9712a256d3d3bd4b14e \
--hash=sha256:a07157588a12518c9d4034df3fbbee09c814741a33ff63c05fa29d26a2404166
pip==25.3 --hash=sha256:9655943313a94722b7774661c21049070f6bbb0a1516bf02f7c8d5d9201514cd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This line is a duplicate entry for the pip package, which is already specified on lines 442-444. This will cause errors during package installation. Please remove this duplicate line.

@mshr-h mshr-h force-pushed the update-python-3.10 branch 3 times, most recently from c44d37a to 30b7396 Compare January 9, 2026 06:44
@mshr-h mshr-h force-pushed the update-python-3.10 branch from 30b7396 to ddb0b23 Compare January 9, 2026 07:51
@tqchen
Copy link
Member

tqchen commented Jan 9, 2026

cc @yongwww

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants