[Relax] Move SymbolicMatcher to tir/analysis

[guan404ming]

Why

The SymbolicMatcher class was previously embedded in src/relax/transform/fuse_tir.cc, making it unavailable for use by other TIR passes. A TODO comment indicated it should be moved to the tir folder for better organization and reusability.

How

Created new files src/tir/analysis/symbolic_matcher.h and src/tir/analysis/symbolic_matcher.cc to house the SymbolicMatcher class

[gemini-code-assist]

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring effort by relocating the SymbolicMatcher class. Previously confined to a specific Relax transformation, this utility is now moved to a dedicated TIR analysis module. This change improves the modularity of the codebase and broadens the accessibility of the symbolic matching functionality to a wider range of TIR passes, aligning with best practices for library design.

Highlights

• Code Relocation: The SymbolicMatcher class, previously embedded within src/relax/transform/fuse_tir.cc, has been moved to a more general location.
• New Files Created: New files src/tir/analysis/symbolic_matcher.h and src/tir/analysis/symbolic_matcher.cc have been created to house the SymbolicMatcher class definition and implementation, respectively.
• Improved Reusability: This refactoring makes the SymbolicMatcher class available for use by other TIR passes, addressing a prior TODO comment and enhancing code organization and reusability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly moves the SymbolicMatcher class from src/relax/transform/fuse_tir.cc to new files under src/tir/analysis/, making it more reusable across different TIR passes. The changes are well-executed and follow the TODO comment in the original code. I've identified a potential correctness issue in the moved SymbolicMatcher logic and a minor style suggestion for your consideration.