Skip to content

improvement(spark): Record the partition choosing sort time for analysis #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zuston merged 1 commit into from
Feb 7, 2025
Merged

improvement(spark): Record the partition choosing sort time for analysis #2364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public class WriteBufferManager extends MemoryConsumer {
private long copyTime = 0;
private long serializeTime = 0;
private long compressTime = 0;
private long sortTime = 0;
private long writeTime = 0;
private long estimateTime = 0;
private long requireMemoryTime = 0;
Expand Down Expand Up @@ -372,9 +373,11 @@ public synchronized List<ShuffleBlockInfo> clear(double bufferSpillRatio) {
bufferSpillRatio = Math.max(0.1, Math.min(1.0, bufferSpillRatio));
List<Integer> partitionList = new ArrayList(buffers.keySet());
if (Double.compare(bufferSpillRatio, 1.0) < 0) {
long start = System.currentTimeMillis();
partitionList.sort(
Comparator.comparingInt(o -> buffers.get(o) == null ? 0 : buffers.get(o).getMemoryUsed())
.reversed());
sortTime += start;
targetSpillSize = (long) ((getUsedBytes() - getInSendListBytes()) * bufferSpillRatio);
}

Expand Down Expand Up @@ -643,6 +646,8 @@ public String getManagerCostInfo() {
+ writeTime
+ "], serializeTime["
+ serializeTime
+ "], sortTime["
+ sortTime
+ "], compressTime["
+ compressTime
+ "], estimateTime["
Expand Down
Loading