More testing for the sql-api & enable custom calcite models for TableScanVisitor #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juripetersen
requested changes
Mar 25, 2025
wayang-api/wayang-api-sql/src/test/java/org/apache/wayang/api/sql/SqlToWayangRelTest.java
Show resolved
Hide resolved
wayang-api/wayang-api-sql/src/test/java/org/apache/wayang/api/sql/SqlToWayangRelTest.java
Show resolved
Hide resolved
wayang-api/wayang-api-sql/src/test/java/org/apache/wayang/api/sql/SqlToWayangRelTest.java
Show resolved
Hide resolved
...ng-api/wayang-api-sql/src/main/java/org/apache/wayang/api/sql/calcite/utils/ModelParser.java
Show resolved
Hide resolved
...pi-sql/src/main/java/org/apache/wayang/api/sql/calcite/converter/WayangTableScanVisitor.java
Outdated
Show resolved
Hide resolved
wayang-api/wayang-api-sql/src/test/java/org/apache/wayang/api/sql/SqlToWayangRelTest.java
Outdated
Show resolved
Hide resolved
wayang-api/wayang-api-sql/src/test/java/org/apache/wayang/api/sql/SqlToWayangRelTest.java
Outdated
Show resolved
Hide resolved
wayang-api/wayang-api-sql/src/test/java/org/apache/wayang/api/sql/SqlToWayangRelTest.java
Outdated
Show resolved
Hide resolved
wayang-api/wayang-api-sql/src/test/java/org/apache/wayang/api/sql/SqlToWayangRelTest.java
Show resolved
Hide resolved
juripetersen
approved these changes
Mar 25, 2025
Contributor
Author
|
Any thoughts on the integration tests failing? I don't think I've changed anything there, and I don't really have time to fix something in other packages, so unless anyone has an idea I'm gonna close the pr. |
Member
|
https://github.com/apache/incubator-wayang/actions/runs/14059491615/job/39366656064?pr=518#step:7:4464 - Tensorflow with a conflicting pattern. @zkaoudi - can you have a look? |
Contributor
|
It doesn't seem like a Tensorflow error. Is it? Sth with the cardinality estimations, right? |
Contributor
Author
|
with #522 can we review this merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a bunch of tests that tests common sql queries that aren't yet supported in the sql-api,
I've left them commented so it doesn't discourage people from pushing working commits yet. I'll have some implementations coming from my personal fork once I verify they are working on 1.0.