Fix join key extraction for python join operator #521
Merged
+61
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkaoudi
requested changes
Mar 31, 2025
Contributor
Author
This test failed for the previous pull requests as well. It's likely an issue introduced in the 1.0.1 version and has nothing to do with this PR. |
Contributor
|
@joker-star-l Maybe you can also help as it's the sparkML that fails for some reason.. |
Contributor
This is caused by dependency conflicts. sparkml 3.1.2 is not work with janino 3.1.8. |
Contributor
|
Thank you Mingxi, indeed it was a dependency issue. |
zkaoudi
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python join operator's key extraction didn't work properly due to incorrect input handling.
This resulted in a cartesian product, as both keys were null.