Skip to content

Fix JOIN clause to reference the correct table in SQL query generation #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kamir merged 1 commit into from
Jan 12, 2026
Merged

Fix JOIN clause to reference the correct table in SQL query generation #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...wayang-jdbc-template/src/main/java/org/apache/wayang/jdbc/operators/JdbcJoinOperator.java
View file
Open in desktop
Copy link
Contributor

@kamir kamir Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem was in the test class:

SELECT * FROM testA JOIN testA ON testB.a=testA.a;

In JdbcJoinOperator.java‎
the code looks good.

Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public String createSqlClause(Connection connection, FunctionCompiler compiler)
final String rightTableName = right.field0;
final String rightKey = right.field1;

return "JOIN " + leftTableName + " ON " +
return "JOIN " + rightTableName + " ON " +
rightTableName + "." + rightKey
+ "=" + leftTableName + "." + leftKey;
}
Expand Down
2 changes: 1 addition & 1 deletion ...ng-jdbc-template/src/test/java/org/apache/wayang/jdbc/operators/JdbcJoinOperatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ void testWithHsqldb() throws SQLException {
System.out.println();

assertEquals(
"SELECT * FROM testA JOIN testA ON testB.a=testA.a;",
"SELECT * FROM testA JOIN testB ON testB.a=testA.a;",
sqlQueryChannelInstance.getSqlQuery()
);
}
Expand Down
Loading