Source, map, collection, sink for bounded data streams in Flink #661
+1,281
−145
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.wayang.flink.channels; | ||
|
|
||
| import org.apache.flink.streaming.api.datastream.DataStream; | ||
| import org.apache.wayang.core.optimizer.OptimizationContext; | ||
| import org.apache.wayang.core.plan.executionplan.Channel; | ||
| import org.apache.wayang.core.plan.wayangplan.OutputSlot; | ||
| import org.apache.wayang.core.platform.AbstractChannelInstance; | ||
| import org.apache.wayang.core.platform.ChannelDescriptor; | ||
| import org.apache.wayang.core.platform.ChannelInstance; | ||
| import org.apache.wayang.core.platform.Executor; | ||
| import org.apache.wayang.flink.execution.FlinkExecutor; | ||
|
|
||
| import java.util.OptionalLong; | ||
|
|
||
| public class DataStreamChannel extends Channel { | ||
|
|
||
| /** | ||
| * {@link ChannelInstance} implementation for {@link DataStream}s. | ||
| */ | ||
| public class Instance extends AbstractChannelInstance { | ||
|
|
||
| private DataStream<?> dataStream; | ||
|
|
||
| // TODO: this.size is currently always 0 | ||
| private long size; | ||
|
|
||
| public Instance(final FlinkExecutor executor, | ||
| final OptimizationContext.OperatorContext producerOperatorContext, | ||
| final int producerOutputIndex) { | ||
| super(executor, producerOperatorContext, producerOutputIndex); | ||
| } | ||
|
|
||
| public void accept(final DataStream<?> dataStream) { | ||
| this.dataStream = dataStream; | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| public <T> DataStream<T> provideDataStream() { | ||
| return (DataStream<T>) this.dataStream; | ||
| } | ||
|
|
||
| @Override | ||
| public OptionalLong getMeasuredCardinality() { | ||
| return this.size == 0 ? super.getMeasuredCardinality() : OptionalLong.of(this.size); | ||
| } | ||
|
|
||
| @Override | ||
| public DataStreamChannel getChannel() { | ||
| return DataStreamChannel.this; | ||
| } | ||
|
|
||
| @Override | ||
| protected void doDispose() { | ||
| this.dataStream = null; | ||
| } | ||
| } | ||
|
|
||
| public static final ChannelDescriptor DESCRIPTOR = new ChannelDescriptor( | ||
| DataStreamChannel.class, true, false); | ||
|
|
||
| public static final ChannelDescriptor DESCRIPTOR_MANY = new ChannelDescriptor( | ||
| DataStreamChannel.class, true, false); | ||
|
|
||
| public DataStreamChannel(final ChannelDescriptor descriptor, final OutputSlot<?> outputSlot) { | ||
| super(descriptor, outputSlot); | ||
| assert descriptor == DESCRIPTOR || descriptor == DESCRIPTOR_MANY; | ||
| this.markForInstrumentation(); | ||
| } | ||
|
|
||
| private DataStreamChannel(final DataStreamChannel parent) { | ||
| super(parent); | ||
| } | ||
|
|
||
| @Override | ||
| public Channel copy() { | ||
| return new DataStreamChannel(this); | ||
| } | ||
|
|
||
| @Override | ||
| public Instance createInstance(final Executor executor, | ||
| final OptimizationContext.OperatorContext producerOperatorContext, | ||
| final int producerOutputIndex) { | ||
| return new Instance((FlinkExecutor) executor, producerOperatorContext, producerOutputIndex); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.wayang.flink.mapping; | ||
|
|
||
| import java.util.Collection; | ||
| import java.util.Collections; | ||
|
|
||
| import org.apache.wayang.basic.operators.TextFileSource; | ||
| import org.apache.wayang.core.mapping.Mapping; | ||
| import org.apache.wayang.core.mapping.OperatorPattern; | ||
| import org.apache.wayang.core.mapping.PlanTransformation; | ||
| import org.apache.wayang.core.mapping.ReplacementSubplanFactory; | ||
| import org.apache.wayang.core.mapping.SubplanPattern; | ||
| import org.apache.wayang.flink.operators.FlinkBoundedTextFileSource; | ||
| import org.apache.wayang.flink.platform.FlinkPlatform; | ||
|
|
||
| public class BoundedTextFileSourceMapping implements Mapping { | ||
|
Contributor
There was a problem hiding this comment. As everything is bounded as of now in Wayang, I would just call this TextFileSource and replace TextFileSource from Flink with it. We can later add a StreamedTextFileSource.
Contributor
Author
There was a problem hiding this comment. Nevertheless since our discussion on continuous streams hasn't concluded either I still propose we keep the bounded semantic as a way to leave the door open for continuous sources later. |
||
| @Override | ||
| public Collection<PlanTransformation> getTransformations() { | ||
| return Collections.singleton(new PlanTransformation( | ||
| this.createSubplanPattern(), | ||
| this.createReplacementSubplanFactory(), | ||
| FlinkPlatform.getInstance() | ||
| )); | ||
| } | ||
|
|
||
| private SubplanPattern createSubplanPattern() { | ||
| final OperatorPattern<?> operatorPattern = new OperatorPattern<>( | ||
| "source", new TextFileSource("", null), false | ||
| ); | ||
| return SubplanPattern.createSingleton(operatorPattern); | ||
| } | ||
|
|
||
| private ReplacementSubplanFactory createReplacementSubplanFactory() { | ||
| return new ReplacementSubplanFactory.OfSingleOperators<TextFileSource>( | ||
| (matchedOperator, epoch) -> new FlinkBoundedTextFileSource(matchedOperator).at(epoch) | ||
| ); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have any effects?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftovers from the old
DataSetChannelimplementation the user could theoretically extend the DataStreamChannel and provide their own, but its such a niche situation I'm fine with removing it.