Skip to content

Conversation

reckart
Copy link
Member

@reckart reckart commented Apr 18, 2025

Mention that Section 5 is sufficient for not significant contributions.

Mention that Section 5 is sufficient for not significant contributions.
@bproffitt bproffitt requested a review from rvs April 18, 2025 11:56
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable.

(Yeah we should have a review from @rvs)

@bproffitt
Copy link
Contributor

@rvs Review on this needed, please.

Copy link
Member

@rvs rvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, I'd rather have: "Contributions that are not significant may be accepted under"

which states that any contribution intentionally submitted for inclusion
shall be under the Apache License 2.0 unless otherwise specified.

All contributors of significant ideas, code, or documentation to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's a better adjective than "significant" -- perhaps we can pick something out of the formal definition of a de minimis-test https://www.lsd.law/define/de-minimis-test ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A contribution is "significant" if reverting the change would be a significant amount of work for the project. Reverting the change might be needed if the contribution is found to be improper, such as occurs when the contributor is not actually the owner of the intellectual property, or the contributor owns a patent and later demands payment for royalties.

which states that any contribution intentionally submitted for inclusion
shall be under the Apache License 2.0 unless otherwise specified.

All contributors of significant ideas, code, or documentation to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change.

Incorporate review comments and move the note up  a bit as to not interfere too much with the CLA section wording.
@reckart
Copy link
Member Author

reckart commented Apr 22, 2025

Thanks for the comments. I have incorporated them into the patch. I also move the change above the CLA section heading as to not interrupt the description of the CLAs too much.

@reckart
Copy link
Member Author

reckart commented Apr 22, 2025

Just to clarify expectations: I expect that once the legal team considers the PR to be final, they merge it. If you want me to press the merge button instead, let me know.

@bproffitt
Copy link
Contributor

Just to clarify expectations: I expect that once the legal team considers the PR to be final, they merge it. If you want me to press the merge button instead, let me know.

Once @rvs approves this, I will merge it.

@clr-apache
Copy link
Contributor

If we include "significant" in the wording, I'd like to include an explanatory paragraph as above. Otherwise, we will need yet another PR to merge the clarification.

@dave2wave
Copy link
Member

@rvs bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants