Skip to content

Commit 6010891

Browse files
committed
remove unused code
1 parent 8c3dab5 commit 6010891

File tree

4 files changed

+3
-39
lines changed

4 files changed

+3
-39
lines changed

zeppelin-web-angular/e2e/models/base-page.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,24 +17,14 @@ export const BASE_URL = 'http://localhost:4200';
1717

1818
export class BasePage {
1919
readonly page: Page;
20-
readonly loadingScreen: Locator;
2120
readonly e2eTestFolder: Locator;
2221

2322
constructor(page: Page) {
2423
this.page = page;
25-
this.loadingScreen = page.locator('section.spin');
2624
this.e2eTestFolder = page.locator(`[data-testid="folder-${E2E_TEST_FOLDER}"]`);
2725
}
2826

2927
async waitForPageLoad(): Promise<void> {
3028
await this.page.waitForLoadState('domcontentloaded', { timeout: 15000 });
3129
}
32-
33-
async clickE2ETestFolder(): Promise<void> {
34-
await this.e2eTestFolder.waitFor({ state: 'visible', timeout: 30000 });
35-
36-
await this.e2eTestFolder.click({ force: true });
37-
38-
await this.page.waitForLoadState('networkidle', { timeout: 15000 });
39-
}
4030
}

zeppelin-web-angular/e2e/models/home-page.ts

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ export class HomePage extends BasePage {
2020
readonly helpSection: Locator;
2121
readonly communitySection: Locator;
2222
readonly createNewNoteButton: Locator;
23-
readonly importNoteButton: Locator;
24-
readonly searchInput: Locator;
2523
readonly filterInput: Locator;
2624
readonly zeppelinLogo: Locator;
2725
readonly anonymousUserIndicator: Locator;
@@ -31,7 +29,6 @@ export class HomePage extends BasePage {
3129
readonly helpCommunityColumn: Locator;
3230
readonly welcomeDescription: Locator;
3331
readonly refreshNoteButton: Locator;
34-
readonly refreshIcon: Locator;
3532
readonly notebookList: Locator;
3633
readonly notebookHeading: Locator;
3734
readonly helpHeading: Locator;
@@ -70,8 +67,6 @@ export class HomePage extends BasePage {
7067
this.helpSection = page.locator('text=Help').first();
7168
this.communitySection = page.locator('text=Community').first();
7269
this.createNewNoteButton = page.getByText('Create new Note', { exact: true }).first();
73-
this.importNoteButton = page.locator('text=Import Note');
74-
this.searchInput = page.locator('textbox', { hasText: 'Search' });
7570
this.filterInput = page.locator('input[placeholder*="Filter"]');
7671
this.zeppelinLogo = page.locator('text=Zeppelin').first();
7772
this.anonymousUserIndicator = page.locator('text=anonymous');
@@ -81,7 +76,6 @@ export class HomePage extends BasePage {
8176
this.helpCommunityColumn = page.locator('[nz-col]').last();
8277
this.welcomeDescription = page.locator('.welcome').getByText('Zeppelin is web-based notebook');
8378
this.refreshNoteButton = page.locator('a.refresh-note');
84-
this.refreshIcon = page.locator('a.refresh-note i[nz-icon]');
8579
this.notebookList = page.locator('zeppelin-node-list');
8680
this.notebookHeading = this.notebookColumn.locator('h3');
8781
this.helpHeading = page.locator('h3').filter({ hasText: 'Help' });
@@ -153,18 +147,10 @@ export class HomePage extends BasePage {
153147
await this.zeppelinLogo.click();
154148
}
155149

156-
async getCurrentURL(): Promise<string> {
157-
return this.page.url();
158-
}
159-
160150
getCurrentPath(): string {
161151
return getCurrentPath(this.page);
162152
}
163153

164-
async getPageTitle(): Promise<string> {
165-
return this.page.title();
166-
}
167-
168154
async getWelcomeHeadingText(): Promise<string> {
169155
const text = await this.welcomeHeading.textContent();
170156
return text || '';
@@ -224,12 +210,4 @@ export class HomePage extends BasePage {
224210
}
225211
return true;
226212
}
227-
228-
async isWelcomeSectionVisible(): Promise<boolean> {
229-
return this.welcomeSection.isVisible();
230-
}
231-
232-
async isMoreInfoGridVisible(): Promise<boolean> {
233-
return this.moreInfoGrid.isVisible();
234-
}
235213
}

zeppelin-web-angular/e2e/models/published-paragraph-page.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,8 @@ import { navigateToNotebookWithFallback } from '../utils';
1515
import { BasePage } from './base-page';
1616

1717
export class PublishedParagraphPage extends BasePage {
18-
readonly publishedParagraphContainer: Locator;
1918
readonly dynamicForms: Locator;
2019
readonly paragraphResult: Locator;
21-
readonly errorModal: Locator;
22-
readonly errorModalTitle: Locator;
2320
readonly errorModalContent: Locator;
2421
readonly errorModalOkButton: Locator;
2522
readonly confirmationModal: Locator;
@@ -28,11 +25,8 @@ export class PublishedParagraphPage extends BasePage {
2825

2926
constructor(page: Page) {
3027
super(page);
31-
this.publishedParagraphContainer = page.locator('zeppelin-publish-paragraph');
3228
this.dynamicForms = page.locator('zeppelin-notebook-paragraph-dynamic-forms');
3329
this.paragraphResult = page.locator('zeppelin-notebook-paragraph-result');
34-
this.errorModal = page.locator('.ant-modal').last();
35-
this.errorModalTitle = page.locator('.ant-modal-title');
3630
this.errorModalContent = this.page.locator('.ant-modal-body', { hasText: 'Paragraph Not Found' }).last();
3731
this.errorModalOkButton = page.getByRole('button', { name: 'OK' }).last();
3832
this.confirmationModal = page.locator('div.ant-modal-confirm').last();

zeppelin-web-angular/e2e/models/published-paragraph-page.util.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,19 @@
1111
*/
1212

1313
import { expect, Page } from '@playwright/test';
14-
import { NOTEBOOK_PATTERNS } from '../utils';
14+
import { NOTEBOOK_PATTERNS, navigateToNotebookWithFallback } from '../utils';
1515
import { NotebookUtil } from './notebook.util';
1616
import { PublishedParagraphPage } from './published-paragraph-page';
1717

1818
export class PublishedParagraphTestUtil {
1919
private page: Page;
2020
private publishedParagraphPage: PublishedParagraphPage;
21+
private notebookUtil: NotebookUtil;
2122

2223
constructor(page: Page) {
2324
this.page = page;
2425
this.publishedParagraphPage = new PublishedParagraphPage(page);
26+
this.notebookUtil = new NotebookUtil(page);
2527
}
2628

2729
async testConfirmationModalForNoResultParagraph({

0 commit comments

Comments
 (0)