Skip to content

Conversation

@sh1nj1
Copy link
Contributor

@sh1nj1 sh1nj1 commented Apr 23, 2025

What is this PR for?

fixes error on running a script to enable Zeppelin as system service

error message:

$ sudo ./bin/zeppelin-systemd-service.sh enable
Failed to enable unit: Unit file zeppelin.service does not exist.
To start Zeppelin using systemd, simply type:
# systemctl start zeppelin

To check the service health:
# systemctl status zeppelin

What type of PR is it?

Bug Fix

Todos

What is the Jira issue?

How should this be tested?

  • sudo ./bin/zeppelin-system-service.sh enable should work without error message.
  • systemctl list-units --all "zeppelin.*" | grep zeppelin should list zeppelin.service.
    output: zeppelin.service loaded inactive dead Apache Zeppelin daemon
  • sudo ./bin/zeppelin-system-service.sh disable should work without error message.
    systemctl list-units --all "zeppelin.*" | grep zeppelin should not list zeppelin.service.
    There should be no /etc/systemd/system/zeppelin.service file.

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@jongyoul
Copy link
Member

@sh1nj1 Thank you for the first contribution. By the way, could you please create a JIRA ticket and add it to your title? https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-6152?filter=allopenissues You might need to register your account on the JIRA here. https://selfserve.apache.org/

@sh1nj1 sh1nj1 changed the title fix: fail on running script to enable system service [ZEPPELIN-6182] fix fail on running script to enable system service Apr 23, 2025
@sh1nj1
Copy link
Contributor Author

sh1nj1 commented Apr 23, 2025

@jongyoul I added ticket ID to the title.

@jongyoul
Copy link
Member

@sh1nj1 What about replacing the filename with zeppelin.service, not moving .systemd to .service?

@sh1nj1
Copy link
Contributor Author

sh1nj1 commented Apr 24, 2025

@jongyoul I changed filename

Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reamer Reamer merged commit 0f7c27d into apache:master Apr 30, 2025
16 of 17 checks passed
asfgit pushed a commit that referenced this pull request Apr 30, 2025
### What is this PR for?

fixes error on running a script to enable Zeppelin as system service

error message:

```
$ sudo ./bin/zeppelin-systemd-service.sh enable
Failed to enable unit: Unit file zeppelin.service does not exist.
To start Zeppelin using systemd, simply type:
# systemctl start zeppelin

To check the service health:
# systemctl status zeppelin
```

### What type of PR is it?
Bug Fix

### Todos

### What is the Jira issue?

* https://issues.apache.org/jira/browse/ZEPPELIN-6182

### How should this be tested?

* `sudo ./bin/zeppelin-system-service.sh enable` should work without error message.
* `systemctl list-units --all "zeppelin.*" | grep zeppelin` should list zeppelin.service.
   output: `  zeppelin.service loaded inactive dead Apache Zeppelin daemon`
* `sudo ./bin/zeppelin-system-service.sh disable` should work without error message.
   `systemctl list-units --all "zeppelin.*" | grep zeppelin` should not list zeppelin.service.
   There should be no /etc/systemd/system/zeppelin.service file.

### Screenshots (if appropriate)

### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Closes #4921 from sh1nj1/fix/system-serivce-sh.

Signed-off-by: Philipp Dallig <[email protected]>
(cherry picked from commit 0f7c27d)
Signed-off-by: Philipp Dallig <[email protected]>
@Reamer
Copy link
Contributor

Reamer commented Apr 30, 2025

Merged into master and branch-0.12

@sh1nj1 sh1nj1 deleted the fix/system-serivce-sh branch April 30, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants