-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ZEPPELIN-6182] fix fail on running script to enable system service #4921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sh1nj1 Thank you for the first contribution. By the way, could you please create a JIRA ticket and add it to your title? https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-6152?filter=allopenissues You might need to register your account on the JIRA here. https://selfserve.apache.org/ |
|
@jongyoul I added ticket ID to the title. |
|
@sh1nj1 What about replacing the filename with |
|
@jongyoul I changed filename |
Reamer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
### What is this PR for? fixes error on running a script to enable Zeppelin as system service error message: ``` $ sudo ./bin/zeppelin-systemd-service.sh enable Failed to enable unit: Unit file zeppelin.service does not exist. To start Zeppelin using systemd, simply type: # systemctl start zeppelin To check the service health: # systemctl status zeppelin ``` ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-6182 ### How should this be tested? * `sudo ./bin/zeppelin-system-service.sh enable` should work without error message. * `systemctl list-units --all "zeppelin.*" | grep zeppelin` should list zeppelin.service. output: ` zeppelin.service loaded inactive dead Apache Zeppelin daemon` * `sudo ./bin/zeppelin-system-service.sh disable` should work without error message. `systemctl list-units --all "zeppelin.*" | grep zeppelin` should not list zeppelin.service. There should be no /etc/systemd/system/zeppelin.service file. ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #4921 from sh1nj1/fix/system-serivce-sh. Signed-off-by: Philipp Dallig <[email protected]> (cherry picked from commit 0f7c27d) Signed-off-by: Philipp Dallig <[email protected]>
|
Merged into master and branch-0.12 |
What is this PR for?
fixes error on running a script to enable Zeppelin as system service
error message:
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
How should this be tested?
sudo ./bin/zeppelin-system-service.sh enableshould work without error message.systemctl list-units --all "zeppelin.*" | grep zeppelinshould list zeppelin.service.output:
zeppelin.service loaded inactive dead Apache Zeppelin daemonsudo ./bin/zeppelin-system-service.sh disableshould work without error message.systemctl list-units --all "zeppelin.*" | grep zeppelinshould not list zeppelin.service.There should be no /etc/systemd/system/zeppelin.service file.
Screenshots (if appropriate)
Questions: