ZOOKEEPER-3938: Upgrade JLine to 3.25.1

[PDavid]

JLine API has been changed between 2x and 3.x quite much so JLineZNodeCompleter and ZooKeeperMain had to be changed quite much.

[PDavid]

Tested this locally the following way:

Created config: cp conf/zoo_sample.cfg conf/zoo.cfg
Built the project: mvn clean install -DskipTests
Started ZooKeeper server: bin/zkServer.sh start
Connected to ZooKeeper server with the client: bin/zkCli.sh -server 127.0.0.1:2181
Created some test ZNodes

create /zk_test my_data
create /zk_test/whatever my_data2
create /zk_test/whatever/alma my_data3
create /zk_test/whatever/other my_data4

"JLine support is enabled" is displayed in the output - OK ✔️

Made sure that completion is working for commands:

2025-09-24 16:50:22,419 [myid:] - INFO  [main:o.a.z.ZooKeeper@1120] - Initiating client connection, connectString=127.0.0.1:2181 sessionTimeout=30000 watcher=org.apache.zookeeper.ZooKeeperMain$MyWatcher@7ea37dbf
2025-09-24 16:50:22,424 [myid:] - INFO  [main:o.a.z.c.X509Util@85] - Setting -D jdk.tls.rejectClientInitiatedRenegotiation=true to disable client-initiated TLS renegotiation
2025-09-24 16:50:22,529 [myid:] - INFO  [main:o.a.z.c.X509Util@109] - Default TLS protocol is TLSv1.3, supported TLS protocols are [TLSv1.3, TLSv1.2, TLSv1.1, TLSv1, SSLv3, SSLv2Hello]
2025-09-24 16:50:22,534 [myid:] - INFO  [main:o.a.z.ClientCnxnSocket@235] - jute.maxbuffer value is 1048575 Bytes
2025-09-24 16:50:22,538 [myid:] - INFO  [main:o.a.z.ClientCnxn@1674] - zookeeper.request.timeout value is 0. feature enabled=false
Welcome to ZooKeeper!
JLine support is enabled
2025-09-24 16:50:22,542 [myid:127.0.0.1:2181] - INFO  [main-SendThread(127.0.0.1:2181):o.a.z.ClientCnxn$SendThread@1121] - Opening socket connection to server localhost/127.0.0.1:2181.
2025-09-24 16:50:22,542 [myid:127.0.0.1:2181] - INFO  [main-SendThread(127.0.0.1:2181):o.a.z.ClientCnxn$SendThread@1123] - SASL config status: Will not attempt to authenticate using SASL (unknown error)
2025-09-24 16:50:22,548 [myid:127.0.0.1:2181] - INFO  [main-SendThread(127.0.0.1:2181):o.a.z.ClientCnxn$SendThread@974] - Socket connection established, initiating session, client: /127.0.0.1:55502, server: localhost/127.0.0.1:2181
2025-09-24 16:50:22,554 [myid:127.0.0.1:2181] - INFO  [main-SendThread(127.0.0.1:2181):o.a.z.ClientCnxn$SendThread@1378] - Session establishment complete on server localhost/127.0.0.1:2181, session id = 0x1000807a7230004, negotiated timeout = 30000

WATCHER::

WatchedEvent state:SyncConnected type:None path:null zxid: -1
[zk: 127.0.0.1:2181(CONNECTED) 0] add
addWatch   addauth

Also for ZNode path-s:

[zk: 127.0.0.1:2181(CONNECTED) 0] ls /z
/zk_test     /zookeeper

[zk: 127.0.0.1:2181(CONNECTED) 0] ls /zk_test/whatever/
/zk_test/whatever/alma    /zk_test/whatever/other

[anmolnar]

Great stuff! lgtm.

[PDavid]

org.apache.zookeeper.server.embedded.ZookeeperServerClusterTest.testStart failed in the PR build. I guess it is not related.

[ctubbsii]

Are there any license file updates with this dependency update?

[PDavid]

Are there any license file updates with this dependency update?

Thanks, good point. Updated the related licence files.

[kezhuw]

Why not 3.30.6 ? The pr title is "ZOOKEEPER-3938: Upgrade JLine to 3.30.6" ?

[PDavid]

Thanks, nice catch. 👍 Actually I had a problem with 30.30.6 that the completer was somehow not invoked. The 3.25.1 version worked fine and this version does not have the https://nvd.nist.gov/vuln/detail/CVE-2023-50572 anymore. But I forgot to update the PR title. :)

EDIT:
Updated the PR title now.

[anmolnar]

Merged to master. Thanks @PDavid !
branch-3.9 has conflicts, please create separate pull request.

[PDavid]

Merged to master. Thanks @PDavid ! branch-3.9 has conflicts, please create separate pull request.

Thanks @anmolnar. 👍 I'll create a PR for branch-3.9.

[PDavid]

The patch did not apply cleanly on branch-3.9 because of a slight local variable name difference in ZooKeeperMain.run(): "completer" vs. "completor" so I had to resolve the conflicts.

Prepared the PR for branch-3.9 here: #2322