Skip to content

Conversation

mudit-saxena
Copy link

 * Tests that the packet queue can grow during a slow/blocked shutdown process.
 * 
 * This test verifies a specific race condition scenario:
 * 1. A background thread continuously adds packets to the learner's queue
 * 2. Shutdown is initiated, which clears the queue and adds proposalOfDeath
 * 3. Shutdown then blocks on socket.close() (mocked to take 5 seconds)
 * 4. During the socket close wait, the background thread continues adding packets
 * 5. The queue grows even though shutdown has been initiated
 * 
 * This simulates real-world scenarios where:
 * - Network I/O is slow during shutdown
 * - The leader continues sending packets while learner is shutting down
 * - The queue can unexpectedly grow during the shutdown process

rahulrane50 and others added 8 commits June 13, 2023 20:12
* Create pull_request_template.md
Updated pull request template with license info to fix rat error.
Issue :
Currently there is single '*' which matches to all branches only if branch do not '/' but since li-dev branches has '/' in it these workflows are not running on them. 

Fix :
Updating CI workflow to run on master and all li-dev branches. Adding explicit branches like master and regex to match all li-dev feature branches.
     * 1. A background thread continuously adds packets to the learner's queue
     * 2. Shutdown is initiated, which clears the queue and adds proposalOfDeath
     * 3. Shutdown then blocks on socket.close() (mocked to take 5 seconds)
     * 4. During the socket close wait, the background thread continues adding packets
     * 5. The queue grows even though shutdown has been initiated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants