Skip to content

feat: support collection export#1448

Merged
earayu merged 1 commit intomainfrom
feature/support_export_col
Mar 4, 2026
Merged

feat: support collection export#1448
earayu merged 1 commit intomainfrom
feature/support_export_col

Conversation

@earayu
Copy link
Collaborator

@earayu earayu commented Mar 4, 2026

Note

Cursor Bugbot is generating a summary for commit 6a8cf2d. Configure here.

@apecloud-bot apecloud-bot added the size/XXL Denotes a PR that changes 1000+ lines. label Mar 4, 2026
@earayu earayu merged commit fee207b into main Mar 4, 2026
5 of 7 checks passed
@earayu earayu deleted the feature/support_export_col branch March 4, 2026 10:18
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Bugbot Free Tier Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

</ReactMarkdown>
);
};
CN/a No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown component destroyed, replaced with "CN/a"

High Severity

The entire markdown.tsx file (321 lines including the Markdown component, mdComponents, rehype/remark plugins, etc.) was replaced with the string CN/a. This component is imported by at least 8 files including message-part-ai.tsx, document-detail.tsx, search-result-drawer.tsx, and others. This will break the entire application since Markdown is no longer exported.

Fix in Cursor Fix in Web

"audit_logs": "Audit Logs",
"quotas": "Quotas",
"prompts": "Prompt Management"
"quotas": "Quotas"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidebar "prompts" translation key removed but still referenced

Medium Severity

The "prompts" key was removed from the sidebar_workspace section of both en-US.json and zh-CN.json, but web/src/app/workspace/menu-footer.tsx still calls sidebar_workspace('prompts') at line 86 to render the sidebar link. This will cause a missing translation, showing a raw key string instead of "Prompt Management".

Additional Locations (1)

Fix in Cursor Fix in Web

downloaded_count[0] += 1

with concurrent.futures.ThreadPoolExecutor(max_workers=MAX_DOWNLOAD_WORKERS) as executor:
executor.map(_download_one, object_paths)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executor.map result not consumed, exceptions silently lost

Medium Severity

The iterator returned by executor.map(_download_one, object_paths) is never consumed. ThreadPoolExecutor.map defers raising exceptions until results are iterated, so any exception thrown inside _download_one (e.g., I/O error writing to disk) is silently swallowed. The export task would proceed to ZIP and report success despite missing files.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants