Merged
Conversation
…nto support/mongodb-sharding-in-0.9
wangyelei
approved these changes
Jun 25, 2025
291f98d to
4d51d64
Compare
wangyelei
approved these changes
Jul 4, 2025
xuriwuyun
reviewed
Jul 8, 2025
| Define mongodb replicaset mode. | ||
| */}} | ||
| {{- define "mongodb-cluster.replicasetMode" }} | ||
| {{- if .Values.useLegacyCompDef }} |
Collaborator
There was a problem hiding this comment.
.Values.useLegacyCompDef can be removed; it is no longer used.
| labels: {{ include "kblib.clusterLabels" . | nindent 4 }} | ||
| {{- if eq .Values.hostnetwork "enabled" }} | ||
| annotations: | ||
| {{- if eq .Values.mode "sharding" }} |
Collaborator
There was a problem hiding this comment.
The sharding topology no longer requires host-network.
| "description": "The number of shards, for sharding mode, the default shards is 3.", | ||
| "type": "integer", | ||
| "default": 3, | ||
| "minimum": 1, |
| sleep $wait_interval | ||
| continue | ||
| fi | ||
|
|
Collaborator
There was a problem hiding this comment.
the while loop can end here
Contributor
Author
There was a problem hiding this comment.
Not Found error occurs frequently, I will set maximum retry count
xuriwuyun
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://github.com/apecloud/syncer/pull/106
pitr requires apecloud/kubeblocks#9404