Conversation
c559070 to
6ad8338
Compare
6ad8338 to
d0901cb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 72 72
Lines 9500 9482 -18
=====================================
+ Misses 9500 9482 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| type: Opaque | ||
| stringData: | ||
| # accounts: | | ||
| # [mechanism=PLAIN] format: |
Contributor
There was a problem hiding this comment.
would it be better to set accounts through helm values
Collaborator
Author
There was a problem hiding this comment.
custom accounts are generally not created during cluster first create; addon users need to add or modify this secret during use.
shanshanying
approved these changes
Nov 26, 2025
cjc7373
approved these changes
Nov 26, 2025
Collaborator
|
/cherry-pick release-1.0 |
Collaborator
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
(cherry picked from commit deae847)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there are some differences in the use of SASL across different versions and architectures of Kafka. this pull request provides an authentication solution that is compatible with all existing versions.
this PR includes built-in SASL (useKBBuildInSasl=true) which only supports mechanisms=plain, future versions will support SCRAM.
users can dynamically maintain their accounts by directly editing the account-secret: