Skip to content

chore: support specify empty password for create redis #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangyelei merged 1 commit into from
Dec 4, 2025
Merged

chore: support specify empty password for create redis #2297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions addons-cluster/redis/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,17 @@ Define redis cluster shardingSpec with ComponentDefinition.
serviceType: LoadBalancer
podService: true
{{- include "kblib.loadBalancerAnnotations" . | indent 4 }}
env:
- name: LOAD_BALANCER_ENABLED
value: "true"
{{- end }}
{{- if and .Values.fixedPodIPEnabled (not .Values.nodePortEnabled) (not .Values.hostNetworkEnabled) (not .Values.loadBalancerEnabled) }}
env:
{{- if .Values.emptyDefaultPassword }}
- name: REDIS_DEFAULT_PASSWORD
value: ""
{{- end }}
{{- if and .Values.loadBalancerEnabled (not .Values.fixedPodIPEnabled) (not .Values.hostNetworkEnabled) (not .Values.nodePortEnabled) }}
- name: LOAD_BALANCER_ENABLED
value: "true"
{{- end }}
{{- if and .Values.fixedPodIPEnabled (not .Values.nodePortEnabled) (not .Values.hostNetworkEnabled) (not .Values.loadBalancerEnabled) }}
- name: FIXED_POD_IP_ENABLED
value: "true"
{{- end }}
Expand Down Expand Up @@ -101,6 +106,10 @@ Define redis ComponentSpec with ComponentDefinition.
- name: LOAD_BALANCER_ENABLED
value: "true"
{{- end }}
{{- if .Values.emptyDefaultPassword }}
- name: REDIS_DEFAULT_PASSWORD
value: ""
{{- end }}
serviceVersion: {{ .Values.version }}
{{- if and .Values.customSecretName .Values.customSecretNamespace }}
systemAccounts:
Expand Down
4 changes: 4 additions & 0 deletions addons-cluster/redis/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,7 @@ extra:

prometheus:
enabled: false

emptyDefaultPassword: false