Skip to content

fix(tidb): add minReadySeconds to fix reconfigure crash#2326

Merged
cjc7373 merged 1 commit intoapecloud:mainfrom
enaguo:fix/tidb-minReadySeconds
Dec 16, 2025
Merged

fix(tidb): add minReadySeconds to fix reconfigure crash#2326
cjc7373 merged 1 commit intoapecloud:mainfrom
enaguo:fix/tidb-minReadySeconds

Conversation

@enaguo
Copy link
Contributor

@enaguo enaguo commented Dec 12, 2025

Fixes #9918

Description

Fix OpsRequest Reconfiguring RestartPolicy issue that causes all instances except the last one to crash on configuration error.

Changes

  • Add minReadySeconds to TiDB ComponentDefinition
  • Prevent all instances except last one from crashing
  • Fix issue when RestartPolicy causes configuration error

Testing

  • Local testing completed
  • Reconfiguration works as expected

Acknowledgments

Thanks to @shanshanying for the suggestion!

Fixes #9918

- Add minReadySeconds to TiDB ComponentDefinition
- Prevent all instances except last one from crashing
- Fix issue when RestartPolicy causes configuration error
@enaguo enaguo requested review from a team, cjc7373 and leon-inf as code owners December 12, 2025 03:43
@apecloud-bot apecloud-bot added the chart-release Auto release chart when PR merged main. label Dec 12, 2025
@wangyelei
Copy link
Contributor

@cjc7373 PTAL

@cjc7373 cjc7373 added the pick-1.0 Auto cherry-pick to release-1.0 when PR merged label Dec 16, 2025
@apecloud-bot apecloud-bot added the chart-release-1.0 Auto release chart when PR merged release-1.0. label Dec 16, 2025
@cjc7373 cjc7373 merged commit 2718632 into apecloud:main Dec 16, 2025
15 of 16 checks passed
@apecloud-bot
Copy link
Collaborator

/cherry-pick release-1.0

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks-addons/actions/runs/20260902361

apecloud-bot pushed a commit that referenced this pull request Dec 16, 2025
Co-authored-by: MOMO <guo.yutian_203025@immomo.com>
(cherry picked from commit 2718632)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart-release Auto release chart when PR merged main. chart-release-1.0 Auto release chart when PR merged release-1.0. pick-1.0 Auto cherry-pick to release-1.0 when PR merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] OpsRequest Reconfiguring: RestartPolicy causes all instances except the last one to crash on configuration error

4 participants