Skip to content

Conversation

@kizuna-lek
Copy link
Collaborator

@kizuna-lek kizuna-lek commented Jan 28, 2026

GetAllParameters adds quotes when handling empty strings

func encodeStringValue(param Item, index int) string {
	buffer := &bytes.Buffer{}
	for i := index; i < len(param.Values); i++ {
		v := param.Values[i]
		if i > index {
			buffer.WriteByte(' ')
		}
		if v == "" || ContainerEscapeString(v) {
			v = strconv.Quote(v)
		}
		buffer.WriteString(v)
	}
	return buffer.String()
}

@kizuna-lek kizuna-lek requested a review from a team as a code owner January 28, 2026 10:00
@kizuna-lek kizuna-lek added pick-0.9 Auto cherry-pick to release-0.9 when PR merged pick-1.0 Auto cherry-pick to release-1.0 when PR merged pick-1.1 Auto cherry-pick to release-1.1 when PR merged labels Jan 28, 2026
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 28, 2026
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 51.41%. Comparing base (548c203) to head (6689013).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/unstructured/redis_config.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10030      +/-   ##
==========================================
+ Coverage   51.35%   51.41%   +0.06%     
==========================================
  Files         539      539              
  Lines       58710    58710              
==========================================
+ Hits        30148    30187      +39     
+ Misses      25611    25578      -33     
+ Partials     2951     2945       -6     
Flag Coverage Δ
unittests 51.41% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 28, 2026
@kizuna-lek
Copy link
Collaborator Author

/approve

@kizuna-lek kizuna-lek merged commit a25b360 into main Jan 28, 2026
73 of 74 checks passed
@kizuna-lek kizuna-lek deleted the bugfix/redis-config-get-string branch January 28, 2026 10:28
@github-actions github-actions bot added this to the Release 1.2.0 milestone Jan 28, 2026
@apecloud-bot
Copy link
Collaborator

/cherry-pick release-1.0

@apecloud-bot
Copy link
Collaborator

/cherry-pick release-1.1

@apecloud-bot
Copy link
Collaborator

/cherry-pick release-0.9

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/21434591089

apecloud-bot pushed a commit that referenced this pull request Jan 28, 2026
@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/21434590666

apecloud-bot pushed a commit that referenced this pull request Jan 28, 2026
@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/21434590556

apecloud-bot pushed a commit that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test pick-0.9 Auto cherry-pick to release-0.9 when PR merged pick-1.0 Auto cherry-pick to release-1.0 when PR merged pick-1.1 Auto cherry-pick to release-1.1 when PR merged size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Redis config GetString and GetAllParameters should remain consistent

4 participants