feat: add hostPorts support to component network configuration#9820
feat: add hostPorts support to component network configuration#9820dudizimber wants to merge 1 commit intoapecloud:mainfrom
Conversation
|
Auto Cherry-pick Instructions |
|
It took me some fiddling to get the project running, but I was able to confirm that this change does behave properly. |
👍🏻 You can set the network.hostNetwork to true instead of adding the annotation. |
Thanks. Let me know if anything else is required before merging. |
| // This will override the container ports defined in component definition. | ||
| // | ||
| // +optional | ||
| HostPorts []HostPortPort `json:"hostPorts,omitempty"` |
There was a problem hiding this comment.
The API should clarify whether all host-network ports need to be specified. Also, if not, what is the default behavior of other ports.
There was a problem hiding this comment.
In addition, how should the ports built into the KB be specified? For example, the HTTP port of kbagent.
| Discrete []int32 `json:"discrete,omitempty"` | ||
| } | ||
|
|
||
| type HostPortPort struct { |
leon-inf
left a comment
There was a problem hiding this comment.
The resolving to host-network ports in Vars also needs to be modified.
|
@leon-inf I'm gonna need some help on this one... |
|
Fixed in #9892 |
fix #9818