Skip to content

fix: enable shared sharding system accounts by default#9890

Merged
leon-inf merged 1 commit intomainfrom
bugfix/shared-sharding-system-account
Nov 26, 2025
Merged

fix: enable shared sharding system accounts by default#9890
leon-inf merged 1 commit intomainfrom
bugfix/shared-sharding-system-account

Conversation

@leon-inf
Copy link
Contributor

close #9887

@leon-inf leon-inf requested a review from a team as a code owner November 24, 2025 07:41
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 24, 2025
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@leon-inf
Copy link
Contributor Author

/pick release-1.0

@leon-inf leon-inf added this to the Release 1.1.0 milestone Nov 24, 2025
@apecloud-bot apecloud-bot added the pick-1.0 Auto cherry-pick to release-1.0 when PR merged label Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.85%. Comparing base (6e1e349) to head (44eed66).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ps/cluster/transformer_cluster_sharding_account.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9890      +/-   ##
==========================================
+ Coverage   50.79%   50.85%   +0.06%     
==========================================
  Files         539      539              
  Lines       58214    58215       +1     
==========================================
+ Hits        29568    29604      +36     
+ Misses      25745    25712      -33     
+ Partials     2901     2899       -2     
Flag Coverage Δ
unittests 50.85% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 26, 2025
@leon-inf leon-inf merged commit 5fa5435 into main Nov 26, 2025
52 checks passed
@leon-inf leon-inf deleted the bugfix/shared-sharding-system-account branch November 26, 2025 03:18
@apecloud-bot
Copy link
Collaborator

/cherry-pick release-1.0

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/19691358703

apecloud-bot pushed a commit that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test pick-1.0 Auto cherry-pick to release-1.0 when PR merged size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] RocketMQ, set shared systemAccounts in ShardingDefinition, cluster stuck in Creating.

5 participants